All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Roland McGrath <roland@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org
Subject: Re: PATCH? tracehook_report_clone: fix false positives
Date: Tue, 2 Jun 2009 02:14:24 +0200	[thread overview]
Message-ID: <20090602001424.GA986@redhat.com> (raw)
In-Reply-To: <20090601231939.223CEFC3C7@magilla.sf.frob.com>

On 06/01, Roland McGrath wrote:
>
> This is where the utrace attachment point has to be (i.e. outside all the
> locking).

Yes I see. Quoting myself:

	Yes, utrace-ptrace will likely change this code further anyway
	and move the code from _init() to _report_clone() back, but in this case
	I guess the whole tracehook_finish_clone() will go away, so this change
	looks right anyway to me.

> So I don't see any benefit to changing the ptrace status quo now
> for its own sake.

OK, agreed.

Oleg.


      reply	other threads:[~2009-06-02  0:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-28 11:36 [RFC PATCH 11/12 v2] ptrace: mv task_struct->ptrace_message ptrace_ctx->message Oleg Nesterov
2009-05-28 11:41 ` Oleg Nesterov
2009-05-28 21:24   ` Roland McGrath
2009-05-29 12:24     ` Oleg Nesterov
2009-05-30 18:52       ` PATCH? tracehook_report_clone: fix false positives Oleg Nesterov
2009-06-01  0:22         ` Roland McGrath
2009-06-01 20:07           ` Oleg Nesterov
2009-06-01 20:50             ` Roland McGrath
2009-06-01 21:34               ` Oleg Nesterov
2009-06-01 23:19                 ` Roland McGrath
2009-06-02  0:14                   ` Oleg Nesterov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090602001424.GA986@redhat.com \
    --to=oleg@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.