From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Mack Subject: Re: [PATCH 2/5] ALSA: snd_usb_caiaq: give better shortname Date: Tue, 2 Jun 2009 12:28:34 +0200 Message-ID: <20090602102834.GF26160@buzzloop.caiaq.de> References: <1243884987-20256-1-git-send-email-daniel@caiaq.de> <1243884987-20256-2-git-send-email-daniel@caiaq.de> <20090602072948.GO26148@buzzloop.caiaq.de> <20090602093104.GC26160@buzzloop.caiaq.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from buzzloop.caiaq.de (buzzloop.caiaq.de [212.112.241.133]) by alsa0.perex.cz (Postfix) with ESMTP id A35E2103835 for ; Tue, 2 Jun 2009 12:28:37 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Jaroslav Kysela Cc: Takashi Iwai , alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Tue, Jun 02, 2009 at 12:11:33PM +0200, Jaroslav Kysela wrote: >> Looks almost good, but we need to check >> snd_info_check_reserved_words() too. >> >> I guess the routine in choose_default_id() can be reused for this >> function, though. >> >> Jaroslav seems working on this now, so maybe he could better cope >> with you... > > Daniel, could you test this patch? > > http://git.alsa-project.org/?p=alsa-kernel.git;a=commitdiff;h=5384d153538ef403c5ca51a6e0c8b85b735c877a Yep - same behaviour than with my patch. Let's take your's :) Thanks, Daniel