From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH v5 1/1] hwmon: added support for the
Date: Tue, 02 Jun 2009 09:12:48 +0000 [thread overview]
Message-ID: <20090602111248.32058e9b@hyperion.delvare> (raw)
In-Reply-To: <20090602081426.6131bdc5@frequentis.com>
On Tue, 2 Jun 2009 08:14:26 +0200, Christian Engelmayer wrote:
> From: Christian Engelmayer <christian.engelmayer@frequentis.com>
>
> Exported the alarm stati provided by the MAX6650/MAX6651 fan-speed regulator
> and monitor chips via sysfs.
>
> Signed-off-by: Christian Engelmayer <christian.engelmayer@frequentis.com>
> ---
> Tested with the MAX6651 chip. This obsoletes the previously proposed patch
> 'support for the max6650 GPIO and alarm features' after discussion on sane
> gpio handling.
>
> Revised after remarks by Hans de Goede. Changed the alarm attributes to sensor
> device attributes thus eliminating the need for pointer comparison in show
> function get_alarm(). Left the alarm behaviour unchanged. In case the sysfs
> interface does not prefer 'real time' over 'latched' alarms I prefer to keep
> the style used by the device.
>
> Incorporated additional remarks by Hans de Goede. Changed a temporary variable
> from 'u8' to 'int'. Changed the order of alarms within the code from MSB first
> to LSB first as occuring within the registers.
>
> Incorporated additional remarks by Jean Delvare. Using attr->index for
> directly passing alarm masks. Resending the patch as it was previously
> corrupted by the mail client.
>
> Incorporated additional remarks on coding style by Jean Delvare. Removed an
> unused preprocessor definition. Reduced comparison operations within an
> infrequently used function.
Applied, thanks! Patch is queued for 2.6.31.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2009-06-02 9:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 6:14 [lm-sensors] [PATCH v5 1/1] hwmon: added support for the max6650 Christian Engelmayer
2009-06-02 9:12 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090602111248.32058e9b@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.