Re: [PATCH RFC v3 3/4] Break dependency between vcpu index in vcpus array and vcpu_id.

[Gleb Natapov <gleb@redhat.com>]

On Tue, Jun 02, 2009 at 09:38:08AM -0300, Marcelo Tosatti wrote:
> > @@ -2223,6 +2226,10 @@ static long kvm_vm_ioctl(struct file *filp,
> >  		r = kvm_irqfd(kvm, data.fd, data.gsi, data.flags);
> >  		break;
> >  	}
> > +	case KVM_SET_BOOT_CPU_ID:
> > +		kvm->bsp_vcpu_id = arg;
> > +		r = 0;
> > +		break;
> 
> Don't you also need to update the bsp_vcpu pointer? And aren't these two
Actually I think I need to return an error if userspace tries to change BSP
after BSP cpu is already created.

> (bsp_vcpu pointer and bsp_vcpu_id) somewhat redundant? 
> 
Sometimes pointer to bsp vcpu is needed. It can be found looping over all
vcpus, but I prefer to have the pointer handy.

--
			Gleb.