From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: add a common exit function for interfaces when manager_free and manager_destroy function is called
Date: Tue, 02 Jun 2009 17:39:13 -0500 [thread overview]
Message-ID: <200906021739.14362.denkenz@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
Hi Minjun,
On Tuesday 02 June 2009 02:02:29 Li, Minjun wrote:
> Hi Folks,
> I regenerated the patch.
> Because I found that manager_destroy function is lack of some exit function
> calls comparing to manager_free function, I add a common exit function for
> interfaces when manager_free and manager_destroy function is called.
>
In interface_exit: Please remove if (at) block, its pointless.
Please get rid of all mode changes, only submit changes to files that are
relevant to the fix.
Get a proper commit message. E.g. put the description in the email into the
commit message.
> Best Regards,
> Minjun
Regards,
-Denis
next reply other threads:[~2009-06-02 22:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 22:39 Denis Kenzior [this message]
[not found] <200906021738.04488.denis.kenzior@intel.com>
2009-06-03 1:11 ` add a common exit function for interfaces when manager_free and manager_destroy function is called Li, Minjun
2009-06-03 2:43 ` Denis Kenzior
-- strict thread matches above, loose matches on Subject: below --
2009-06-02 7:02 Li, Minjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906021739.14362.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.