From: Andreas Herrmann <andreas.herrmann3@amd.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org, Bert Wesarg <bert.wesarg@googlemail.com>
Subject: [PATCH 5/5] x86: mcheck: make use of cpu_node_mask instead of cpu_core_mask to support multi-node processors
Date: Wed, 3 Jun 2009 16:44:43 +0200 [thread overview]
Message-ID: <20090603144443.GN5736@alberich.amd.com> (raw)
In-Reply-To: <20090603142727.GI5736@alberich.amd.com>
This fixes threshold_bank4 support.
We need to create symlinks for sibling shared banks to first core of
each internal node and not to first core of one internal node.
Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
---
arch/x86/kernel/cpu/mcheck/mce_amd_64.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kernel/cpu/mcheck/mce_amd_64.c b/arch/x86/kernel/cpu/mcheck/mce_amd_64.c
index ddae216..595cbe5 100644
--- a/arch/x86/kernel/cpu/mcheck/mce_amd_64.c
+++ b/arch/x86/kernel/cpu/mcheck/mce_amd_64.c
@@ -494,7 +494,7 @@ static __cpuinit int threshold_create_bank(unsigned int cpu, unsigned int bank)
#ifdef CONFIG_SMP
if (cpu_data(cpu).cpu_core_id && shared_bank[bank]) { /* symlink */
- i = cpumask_first(cpu_core_mask(cpu));
+ i = cpumask_first(cpu_node_mask(cpu));
/* first core not up yet */
if (cpu_data(i).cpu_core_id)
@@ -514,7 +514,7 @@ static __cpuinit int threshold_create_bank(unsigned int cpu, unsigned int bank)
if (err)
goto out;
- cpumask_copy(b->cpus, cpu_core_mask(cpu));
+ cpumask_copy(b->cpus, cpu_node_mask(cpu));
per_cpu(threshold_banks, cpu)[bank] = b;
goto out;
@@ -539,7 +539,7 @@ static __cpuinit int threshold_create_bank(unsigned int cpu, unsigned int bank)
#ifndef CONFIG_SMP
cpumask_setall(b->cpus);
#else
- cpumask_copy(b->cpus, cpu_core_mask(cpu));
+ cpumask_copy(b->cpus, cpu_node_mask(cpu));
#endif
per_cpu(threshold_banks, cpu)[bank] = b;
--
1.6.3.1
next prev parent reply other threads:[~2009-06-03 14:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-03 14:27 [PATCH 0/5 v3] x86: adapt CPU topology detection for AMD Magny-Cours Andreas Herrmann
2009-06-03 14:29 ` [PATCH 1/5] topology: introduce cpu_node information for multi-node processors Andreas Herrmann
2009-06-03 14:33 ` Bert Wesarg
2009-06-03 14:34 ` [PATCH 2/5] x86: provide CPU topology " Andreas Herrmann
2009-06-03 14:35 ` [PATCH 3/5] x86: add cpu_node topology detection for AMD Magny-Cours Andreas Herrmann
2009-06-03 14:48 ` Bert Wesarg
2009-06-03 15:16 ` [PATCH 3/5 retry] " Andreas Herrmann
2009-06-03 14:37 ` [PATCH 4/5] x86: cacheinfo: fixup L3 cache information " Andreas Herrmann
2009-06-03 14:44 ` Andreas Herrmann [this message]
2009-06-07 13:40 ` [PATCH 0/5 v3] x86: adapt CPU topology detection " Ingo Molnar
2009-06-11 15:38 ` Andreas Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090603144443.GN5736@alberich.amd.com \
--to=andreas.herrmann3@amd.com \
--cc=bert.wesarg@googlemail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.