From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [PATCH 2/4] cgroup freezer: Avoid lazy state changes when convenient Date: Wed, 3 Jun 2009 14:52:30 -0500 Message-ID: <20090603195230.GA11761@us.ibm.com> References: <03412f8681d89c99ac575330381ab49f6e5e61ba.1244019829.git.matthltc@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <03412f8681d89c99ac575330381ab49f6e5e61ba.1244019829.git.matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Matt Helsley Cc: Containers , Paul Menage List-Id: containers.vger.kernel.org Quoting Matt Helsley (matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org): > When all the tasks of a cgroup were successfully frozen we can avoid > the lazy FREEZING -> FROZEN transition and move into FROZEN during the > write to freezer.state. > > Signed-off-by: Matt Helsley Acked-by: Serge Hallyn > --- > kernel/cgroup_freezer.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/kernel/cgroup_freezer.c b/kernel/cgroup_freezer.c > index 765e2c1..19702ac 100644 > --- a/kernel/cgroup_freezer.c > +++ b/kernel/cgroup_freezer.c > @@ -286,7 +286,10 @@ static int try_to_freeze_cgroup(struct cgroup *cgroup, struct freezer *freezer) > } > cgroup_iter_end(cgroup, &it); > > - return num_cant_freeze_now ? -EBUSY : 0; > + if (num_cant_freeze_now) > + return -EBUSY; > + freezer->state = CGROUP_FROZEN; > + return 0; > } > > static void unfreeze_cgroup(struct cgroup *cgroup, struct freezer *freezer) > -- > 1.5.6.3 > > > _______________________________________________ > Containers mailing list > Containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org > https://lists.linux-foundation.org/mailman/listinfo/containers