From: Andi Kleen <andi@firstfloor.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Michal Marek <mmarek@suse.cz>, Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] kbuild: some scripts/config improvements (try 2)
Date: Wed, 3 Jun 2009 22:16:46 +0200 [thread overview]
Message-ID: <20090603201645.GG1065@one.firstfloor.org> (raw)
In-Reply-To: <20090603192520.GC3100@uranus.ravnborg.org>
On Wed, Jun 03, 2009 at 09:25:20PM +0200, Sam Ravnborg wrote:
> On Mon, May 25, 2009 at 04:43:20PM +0200, Michal Marek wrote:
> > Hi,
> >
> > I simplified the awk script a bit, made it awk ... && mv and removed the
> > --set option.
> >
> > Michal Marek (3):
> > kbuild: handle non-existing options in scripts/config
> > kbuild: simplify argument loop in scripts/config
> > kbuild: add generic --set-str option to scripts/config
>
> Andi - do I have your ack on this serie?
Reluctantly -- most bits are ok, but the awk change seems quite overcomplicated
and I don't like it particularly.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-06-03 20:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-25 14:43 [PATCH 0/3] kbuild: some scripts/config improvements (try 2) Michal Marek
2009-06-03 19:25 ` Sam Ravnborg
2009-06-03 20:16 ` Andi Kleen [this message]
2009-06-04 5:47 ` Michal Marek
2009-06-14 20:48 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090603201645.GG1065@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.