From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: Eric Miao <eric.y.miao@gmail.com>,
alsa-devel@alsa-project.org,
Russell King - ARM Linux <linux@arm.linux.org.uk>
Subject: Re: [PATCH] Fix possibly incorrect offset in wm97xx-core
Date: Thu, 4 Jun 2009 09:46:03 +0100 [thread overview]
Message-ID: <20090604084602.GA6983@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <200906032344.37640.marek.vasut@gmail.com>
On Wed, Jun 03, 2009 at 11:44:37PM +0200, Marek Vasut wrote:
> - if (wm->id == WM9712_ID2)
> - wm97xx_reg_write(wm, AC97_GPIO_STATUS, (status &
> - ~WM97XX_GPIO_13) << 1);
> - else
> - wm97xx_reg_write(wm, AC97_GPIO_STATUS, status &
> + wm97xx_reg_write(wm, AC97_GPIO_STATUS, status &
> ~WM97XX_GPIO_13);
Nack, the existing code reflects the behaviour of the silicon.
next prev parent reply other threads:[~2009-06-04 8:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-03 21:44 [PATCH] Fix possibly incorrect offset in wm97xx-core Marek Vasut
2009-06-04 8:46 ` Mark Brown [this message]
2009-06-04 9:59 ` Marek Vasut
2009-06-04 11:06 ` Mark Brown
2009-06-04 20:05 ` Marek Vasut
2009-06-05 8:51 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090604084602.GA6983@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=eric.y.miao@gmail.com \
--cc=linux@arm.linux.org.uk \
--cc=marek.vasut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.