From: Jean Delvare <khali@linux-fr.org>
To: alsa-devel@alsa-project.org
Cc: Kyle McMartin <kyle@mcmartin.ca>, Takashi Iwai <tiwai@suse.de>
Subject: [PATCH] ALSA: Add missing __devexit_p() markers
Date: Thu, 4 Jun 2009 10:46:43 +0200 [thread overview]
Message-ID: <20090604104643.443fbe52@hyperion.delvare> (raw)
3 ISA sound drivers lack their __devexit_p() markers, which would
cause build failures when the kernel is built without hotplug support.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Kyle McMartin <kyle@mcmartin.ca>
Cc: Takashi Iwai <tiwai@suse.de>
---
sound/isa/es1688/es1688.c | 2 +-
sound/isa/gus/gusextreme.c | 2 +-
sound/parisc/harmony.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
--- linux-2.6.30-rc8.orig/sound/isa/es1688/es1688.c 2009-04-08 08:54:02.000000000 +0200
+++ linux-2.6.30-rc8/sound/isa/es1688/es1688.c 2009-06-04 10:37:06.000000000 +0200
@@ -193,7 +193,7 @@ static int __devexit snd_es1688_remove(s
static struct isa_driver snd_es1688_driver = {
.match = snd_es1688_match,
.probe = snd_es1688_probe,
- .remove = snd_es1688_remove,
+ .remove = __devexit_p(snd_es1688_remove),
#if 0 /* FIXME */
.suspend = snd_es1688_suspend,
.resume = snd_es1688_resume,
--- linux-2.6.30-rc8.orig/sound/isa/gus/gusextreme.c 2009-04-08 08:54:02.000000000 +0200
+++ linux-2.6.30-rc8/sound/isa/gus/gusextreme.c 2009-06-04 10:37:13.000000000 +0200
@@ -348,7 +348,7 @@ static int __devexit snd_gusextreme_remo
static struct isa_driver snd_gusextreme_driver = {
.match = snd_gusextreme_match,
.probe = snd_gusextreme_probe,
- .remove = snd_gusextreme_remove,
+ .remove = __devexit_p(snd_gusextreme_remove),
#if 0 /* FIXME */
.suspend = snd_gusextreme_suspend,
.resume = snd_gusextreme_resume,
--- linux-2.6.30-rc8.orig/sound/parisc/harmony.c 2009-04-08 08:54:03.000000000 +0200
+++ linux-2.6.30-rc8/sound/parisc/harmony.c 2009-06-04 10:37:25.000000000 +0200
@@ -1020,7 +1020,7 @@ static struct parisc_driver snd_harmony_
.name = "harmony",
.id_table = snd_harmony_devtable,
.probe = snd_harmony_probe,
- .remove = snd_harmony_remove,
+ .remove = __devexit_p(snd_harmony_remove),
};
static int __init
--
Jean Delvare
next reply other threads:[~2009-06-04 8:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 8:46 Jean Delvare [this message]
2009-06-04 8:53 ` [PATCH] ALSA: Add missing __devexit_p() markers Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090604104643.443fbe52@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=alsa-devel@alsa-project.org \
--cc=kyle@mcmartin.ca \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.