From: Theodore Tso <tytso@mit.edu>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: cmm@us.ibm.com, sandeen@redhat.com, linux-ext4@vger.kernel.org,
Jan Kara <jack@suse.cz>
Subject: Re: [PATCH -V2 4/4] ext4: Add WARN_ON on unmapped dirty buffer_heads in writepage
Date: Thu, 4 Jun 2009 09:50:45 -0400 [thread overview]
Message-ID: <20090604135045.GJ21314@mit.edu> (raw)
In-Reply-To: <1244095805-17015-4-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
On Thu, Jun 04, 2009 at 11:40:05AM +0530, Aneesh Kumar K.V wrote:
> Now we have block_lock_hole_extend clearing the dirty flag of
> buffer_heads outside i_size we should not find buffer_heads
> which are unmapped and dirty in writepage. If we find do a WARN_ON.
> We can still continue because block_write_full page look at the mapped
> flag only.
This is only true only *after* Jan's patches are applied, right? So
that means it's only safe to apply this after Jan's patch series is
applied. So I believe I need to queue this in the unstable portion of
the patch queue until the page_mkwrite() changes are applied;
otherwise we could have some spurious WARN_ON's.
- Ted
next prev parent reply other threads:[~2009-06-04 13:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 6:10 [PATCH -V2 1/4] ext4: Check for only delay or unwritten buffer_heads Aneesh Kumar K.V
2009-06-04 6:10 ` [PATCH -V2 2/4] ext4: Add generic writepage callback Aneesh Kumar K.V
2009-06-04 6:10 ` [PATCH -V2 3/4] ext4: Move some static functions around Aneesh Kumar K.V
2009-06-04 6:10 ` [PATCH -V2 4/4] ext4: Add WARN_ON on unmapped dirty buffer_heads in writepage Aneesh Kumar K.V
2009-06-04 13:50 ` Theodore Tso [this message]
2009-06-04 13:47 ` [PATCH -V2 3/4] ext4: Move some static functions around Theodore Tso
2009-06-04 12:05 ` [PATCH -V2 2/4] ext4: Add generic writepage callback Theodore Tso
2009-06-04 13:20 ` Theodore Tso
2009-06-04 13:16 ` [PATCH -V2 1/4] ext4: Check for only delay or unwritten buffer_heads Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090604135045.GJ21314@mit.edu \
--to=tytso@mit.edu \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=cmm@us.ibm.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.