All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Greg KH <gregkh@suse.de>, Alan Stern <stern@rowland.harvard.edu>,
	Frans Pop <elendil@planet.nl>,
	pm list <linux-pm@lists.linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH] USB: Avoid PM error messages during resume if a device was disconnected
Date: Thu, 4 Jun 2009 14:02:48 -0700	[thread overview]
Message-ID: <20090604210248.GA17039@kroah.com> (raw)
In-Reply-To: <200906042230.49825.rjw@sisk.pl>

On Thu, Jun 04, 2009 at 10:30:48PM +0200, Rafael J. Wysocki wrote:
> From: Frans Pop <elendil@planet.nl>
> 
> Currently if a laptop is suspended e.g. while docked and then resumed after
> undocking it, the following errors get generated because the USB hub in the
> docking station and the devices connected to it are no longer available:
> pm_op(): usb_dev_resume+0x0/0x10 returns -19
> PM: Device 1-2 failed to resume: error -19
> pm_op(): usb_dev_resume+0x0/0x10 returns -19
> PM: Device 1-2.2 failed to resume: error -19
> pm_op(): usb_dev_resume+0x0/0x10 returns -19
> PM: Device 1-2.3 failed to resume: error -19
> 
> As the removal of USB devices while a system is suspended is a relatively
> common use case and in most cases not an error, just return success on
> -ENODEV. The user gets informed anyway as the USB subsystem generates
> regular disconnect messages for the devices shortly afterwards:
> usb 1-2: USB disconnect, address 3
> usb 1-2.2: USB disconnect, address 4
> usblp0: removed
> usb 1-2.3: USB disconnect, address 5
> 
> Signed-off-by: Frans Pop <elendil@planet.nl>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> ---
> Hi Greg,
> 
> I can take this patch to the suspend tree, but if you think it should go
> through USB, please consider including it into the 2.6.31 push.

I've now queued it up in my usb tree, as that is probably the best place
for it.

thanks,

greg k-h

  reply	other threads:[~2009-06-04 21:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-04 20:30 [PATCH] USB: Avoid PM error messages during resume if a device was disconnected Rafael J. Wysocki
2009-06-04 21:02 ` Greg KH [this message]
2009-06-04 21:02 ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2009-06-04 20:30 Rafael J. Wysocki
2009-03-23 21:11 [PATCH] usb: avoid " Frans Pop
2009-03-23 21:11 Frans Pop
2009-03-23 21:30 ` Frans Pop
2009-03-23 21:30 ` Frans Pop
2009-03-23 21:44 ` Alan Stern
2009-03-23 22:25   ` Frans Pop
2009-03-23 22:25   ` Frans Pop
2009-03-24 14:11     ` Alan Stern
2009-06-02 21:26       ` Rafael J. Wysocki
2009-06-02 21:26       ` Rafael J. Wysocki
2009-06-02 21:48         ` Alan Stern
2009-06-02 21:48         ` Alan Stern
2009-06-02 21:48         ` Alan Stern
2009-03-24 14:11     ` Alan Stern
2009-03-23 21:44 ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090604210248.GA17039@kroah.com \
    --to=greg@kroah.com \
    --cc=elendil@planet.nl \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.