All of lore.kernel.org
 help / color / mirror / Atom feed
From: Magnus Damm <magnus.damm@gmail.com>
To: linux-pm@lists.linux-foundation.org
Cc: ben-linux@fluff.org, hskinnemoen@atmel.com, anemo@mba.ocn.ne.jp,
	gregkh@suse.de, rjw@sisk.pl, stern@rowland.harvard.edu,
	pavel@ucw.cz, felipe.balbi@nokia.com, linux-omap@vger.kernel.org,
	Magnus Damm <magnus.damm@gmail.com>
Subject: [PATCH 07/07] pm: remove platform device suspend_late()/resume_early()
Date: Fri, 05 Jun 2009 16:55:42 +0900	[thread overview]
Message-ID: <20090605075542.14756.99380.sendpatchset@rx1.opensource.se> (raw)
In-Reply-To: <20090605075436.14756.80501.sendpatchset@rx1.opensource.se>

From: Magnus Damm <damm@igel.co.jp>

This patch removes the legacy platform driver power management
callbacks ->suspend_late() and ->resume_early() since all in-tree
users have been migrated to dev_pm_ops.

Signed-off-by: Magnus Damm <damm@igel.co.jp>
---

 Untested but compiles fine.

 drivers/base/platform.c         |   36 ------------------------------------
 include/linux/platform_device.h |    2 --
 2 files changed, 38 deletions(-)

--- 0001/drivers/base/platform.c
+++ work/drivers/base/platform.c	2009-06-01 15:27:57.000000000 +0900
@@ -642,30 +642,6 @@ static int platform_legacy_suspend(struc
 	return ret;
 }
 
-static int platform_legacy_suspend_late(struct device *dev, pm_message_t mesg)
-{
-	struct platform_driver *pdrv = to_platform_driver(dev->driver);
-	struct platform_device *pdev = to_platform_device(dev);
-	int ret = 0;
-
-	if (dev->driver && pdrv->suspend_late)
-		ret = pdrv->suspend_late(pdev, mesg);
-
-	return ret;
-}
-
-static int platform_legacy_resume_early(struct device *dev)
-{
-	struct platform_driver *pdrv = to_platform_driver(dev->driver);
-	struct platform_device *pdev = to_platform_device(dev);
-	int ret = 0;
-
-	if (dev->driver && pdrv->resume_early)
-		ret = pdrv->resume_early(pdev);
-
-	return ret;
-}
-
 static int platform_legacy_resume(struct device *dev)
 {
 	int ret = 0;
@@ -726,8 +702,6 @@ static int platform_pm_suspend_noirq(str
 	if (drv->pm) {
 		if (drv->pm->suspend_noirq)
 			ret = drv->pm->suspend_noirq(dev);
-	} else {
-		ret = platform_legacy_suspend_late(dev, PMSG_SUSPEND);
 	}
 
 	return ret;
@@ -762,8 +736,6 @@ static int platform_pm_resume_noirq(stru
 	if (drv->pm) {
 		if (drv->pm->resume_noirq)
 			ret = drv->pm->resume_noirq(dev);
-	} else {
-		ret = platform_legacy_resume_early(dev);
 	}
 
 	return ret;
@@ -809,8 +781,6 @@ static int platform_pm_freeze_noirq(stru
 	if (drv->pm) {
 		if (drv->pm->freeze_noirq)
 			ret = drv->pm->freeze_noirq(dev);
-	} else {
-		ret = platform_legacy_suspend_late(dev, PMSG_FREEZE);
 	}
 
 	return ret;
@@ -845,8 +815,6 @@ static int platform_pm_thaw_noirq(struct
 	if (drv->pm) {
 		if (drv->pm->thaw_noirq)
 			ret = drv->pm->thaw_noirq(dev);
-	} else {
-		ret = platform_legacy_resume_early(dev);
 	}
 
 	return ret;
@@ -881,8 +849,6 @@ static int platform_pm_poweroff_noirq(st
 	if (drv->pm) {
 		if (drv->pm->poweroff_noirq)
 			ret = drv->pm->poweroff_noirq(dev);
-	} else {
-		ret = platform_legacy_suspend_late(dev, PMSG_HIBERNATE);
 	}
 
 	return ret;
@@ -917,8 +883,6 @@ static int platform_pm_restore_noirq(str
 	if (drv->pm) {
 		if (drv->pm->restore_noirq)
 			ret = drv->pm->restore_noirq(dev);
-	} else {
-		ret = platform_legacy_resume_early(dev);
 	}
 
 	return ret;
--- 0002/include/linux/platform_device.h
+++ work/include/linux/platform_device.h	2009-06-01 15:27:57.000000000 +0900
@@ -60,8 +60,6 @@ struct platform_driver {
 	int (*remove)(struct platform_device *);
 	void (*shutdown)(struct platform_device *);
 	int (*suspend)(struct platform_device *, pm_message_t state);
-	int (*suspend_late)(struct platform_device *, pm_message_t state);
-	int (*resume_early)(struct platform_device *);
 	int (*resume)(struct platform_device *);
 	struct device_driver driver;
 	struct platform_device_id *id_table;

  parent reply	other threads:[~2009-06-05  7:59 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-05  7:54 [PATCH 00/07] pm: remove late/early platform driver pm callbacks Magnus Damm
2009-06-05  7:54 ` [PATCH 01/07] arm: rework omap suspend_late()/resume_early() Magnus Damm
2009-06-05  7:54 ` Magnus Damm
2009-06-05  7:54 ` [PATCH 02/07] dma: rework dw_dmac suspend_late()/resume_early() Magnus Damm
2009-06-05  8:18   ` Haavard Skinnemoen
2009-06-05  8:34     ` Magnus Damm
2009-06-05  8:34     ` Magnus Damm
2009-06-05  8:45       ` Haavard Skinnemoen
2009-06-05  8:45       ` Haavard Skinnemoen
2009-06-05  8:18   ` Haavard Skinnemoen
2009-06-05  7:54 ` Magnus Damm
2009-06-05  7:55 ` [PATCH 03/07] dma: rework txx9dmac suspend_late()/resume_early() Magnus Damm
2009-06-05  7:55 ` Magnus Damm
2009-06-05  7:55 ` [PATCH 04/07] i2c: rework i2c-pxa suspend_late()/resume_early() Magnus Damm
2009-06-05  7:55 ` Magnus Damm
2009-06-05  7:55 ` [PATCH 05/07] i2c: rework i2c-s3c2410 suspend_late()/resume() Magnus Damm
2009-06-05  7:55 ` Magnus Damm
2009-06-05  7:55 ` [PATCH 06/07] usb: rework musb suspend()/resume_early() Magnus Damm
2009-06-05  7:55 ` Magnus Damm
2009-06-05  7:55 ` Magnus Damm [this message]
2009-06-05  7:55 ` [PATCH 07/07] pm: remove platform device suspend_late()/resume_early() Magnus Damm
2009-06-05 19:10 ` [PATCH 00/07] pm: remove late/early platform driver pm callbacks Rafael J. Wysocki
2009-06-05 19:10 ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090605075542.14756.99380.sendpatchset@rx1.opensource.se \
    --to=magnus.damm@gmail.com \
    --cc=anemo@mba.ocn.ne.jp \
    --cc=ben-linux@fluff.org \
    --cc=felipe.balbi@nokia.com \
    --cc=gregkh@suse.de \
    --cc=hskinnemoen@atmel.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=pavel@ucw.cz \
    --cc=rjw@sisk.pl \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.