All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Amerigo Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	sam@ravnborg.org, linux-kbuild@vger.kernel.org
Subject: Re: [Patch] kbuild: fix headers_check.pl
Date: Fri, 5 Jun 2009 10:21:50 +0100	[thread overview]
Message-ID: <200906051021.51726.arnd@arndb.de> (raw)
In-Reply-To: <20090605021419.7905.89870.sendpatchset@localhost.localdomain>

On Friday 05 June 2009, Amerigo Wang wrote:
> -sub check_prototypes
> +sub check_declarations
>  {
> -       if ($line =~ m/^\s*extern\b/) {
> -               printf STDERR "$filename:$lineno: extern's make no sense in userspace\n";
> +       if ($line =~m/^\s*extern\b/) {
> +               if ($line =~ m/^\s*extern\b.*\(.*\)/) {
> +                       printf STDERR "$filename:$lineno: extern's make no sense in userspace\n";
> +               } else {
> +                       printf STDERR "$filename:$lineno: exporting global variable to userspace is suspicious\n";
> +               }
>         }
>  }

I don't think we really need that distinction here, the old
text applies to both. But please find a way to get rid of
the "extern's".

http://angryflower.com/bobsqu.gif

	Arnd <><

  parent reply	other threads:[~2009-06-05  9:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-05  2:12 [Patch] kbuild: fix headers_check.pl Amerigo Wang
2009-06-05  2:12 ` [Patch] kbuild: clean up scripts/headers.sh Amerigo Wang
2009-06-05 21:41   ` Sam Ravnborg
2009-06-05  9:21 ` Arnd Bergmann [this message]
2009-06-05 10:22   ` [Patch] kbuild: fix headers_check.pl Amerigo Wang
2009-06-05 12:31     ` Arnd Bergmann
2009-06-05 11:26   ` Artem Bityutskiy
2009-06-05 21:41 ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906051021.51726.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=akpm@linux-foundation.org \
    --cc=amwang@redhat.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.