From: Andrew Morton <akpm@linux-foundation.org>
To: Pekka J Enberg <penberg@cs.helsinki.fi>
Cc: corentincj@iksaif.net, acpi4asus-user@lists.sourceforge.net,
len.brown@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] eeepc-laptop: enable camera by default
Date: Fri, 5 Jun 2009 13:08:35 -0700 [thread overview]
Message-ID: <20090605130835.e21eaf37.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0906051157460.22218@melkki.cs.Helsinki.FI>
On Fri, 5 Jun 2009 11:59:41 +0300 (EEST)
Pekka J Enberg <penberg@cs.helsinki.fi> wrote:
> /*
> + * Camera helpers
> + */
> +
> +static void eeepc_enable_camera(void)
> +{
> + int err;
> +
> + err = set_acpi(CM_ASL_CAMERA, 1);
> + if (err)
> + printk(EEEPC_WARNING "Unable to enable camera %d\n", err);
> +}
> +
> +/*
> * Sys helpers
> */
> static int parse_arg(const char *buf, unsigned long count, int *val)
> @@ -996,6 +1009,9 @@ static int __init eeepc_laptop_init(void)
We can do this:
--- a/drivers/platform/x86/eeepc-laptop.c~eeepc-laptop-enable-camera-by-default-fix
+++ a/drivers/platform/x86/eeepc-laptop.c
@@ -334,7 +334,7 @@ static const struct rfkill_ops eeepc_rfk
* Camera helpers
*/
-static void eeepc_enable_camera(void)
+static void __init eeepc_enable_camera(void)
{
int err;
_
if we're so inclined?
next prev parent reply other threads:[~2009-06-05 20:09 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 8:59 [PATCH] eeepc-laptop: enable camera by default Pekka J Enberg
2009-06-05 11:46 ` Corentin Chary
2009-06-05 12:44 ` Pekka Enberg
2009-06-05 13:02 ` Corentin Chary
2009-06-05 13:39 ` Alan Jenkins
2009-06-05 13:51 ` Pekka Enberg
2009-06-05 13:54 ` Pekka Enberg
2009-06-05 13:58 ` Corentin Chary
2009-06-05 14:38 ` Alan Jenkins
2009-06-05 14:50 ` Pekka Enberg
2009-06-05 14:55 ` Alan Jenkins
2009-06-05 15:08 ` Alan Jenkins
2009-06-05 15:14 ` Pekka Enberg
2009-06-07 14:54 ` Darren Salt
2009-06-07 15:41 ` Alan Jenkins
2009-06-07 23:28 ` Matthew Garrett
2009-06-08 3:03 ` Alan Stern
2009-06-08 3:07 ` Matthew Garrett
2009-06-08 3:10 ` Alan Stern
2009-06-08 15:00 ` Matthew Garrett
2009-06-08 20:44 ` Alan Stern
2009-06-05 15:13 ` Alan Stern
2009-06-05 15:22 ` Pekka Enberg
2009-06-05 21:01 ` Woody Suwalski
2009-06-06 7:12 ` Corentin Chary
2009-06-06 8:04 ` Alan Jenkins
2009-06-05 20:08 ` Andrew Morton [this message]
2009-06-06 7:25 ` Corentin Chary
2009-06-06 7:31 ` Andrew Morton
2009-06-06 7:52 ` Corentin Chary
2009-06-06 9:17 ` Pekka Enberg
2009-06-06 10:17 ` Corentin Chary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090605130835.e21eaf37.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=corentincj@iksaif.net \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.