From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MCcYS-0003Yb-7z for mharc-grub-devel@gnu.org; Fri, 05 Jun 2009 12:46:08 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MCcYP-0003Wf-Oo for grub-devel@gnu.org; Fri, 05 Jun 2009 12:46:05 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MCcYL-0003VU-BT for grub-devel@gnu.org; Fri, 05 Jun 2009 12:46:05 -0400 Received: from [199.232.76.173] (port=36869 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MCcYL-0003VR-5a for grub-devel@gnu.org; Fri, 05 Jun 2009 12:46:01 -0400 Received: from aybabtu.com ([69.60.117.155]:43017) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MCcYK-0007UD-Ob for grub-devel@gnu.org; Fri, 05 Jun 2009 12:46:00 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MCbWr-00019E-Fh; Fri, 05 Jun 2009 17:40:26 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MCcYE-0001MR-Mu; Fri, 05 Jun 2009 18:45:54 +0200 Date: Fri, 5 Jun 2009 18:45:54 +0200 From: Robert Millan To: Vladimir 'phcoder' Serbinenko Message-ID: <20090605164554.GE5177@thorin> References: <200906032352.51827.dron@osrc.info> <200906050007.20241.dron@osrc.info> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Cc: The development of GRUB 2 Subject: Re: multiboot take partial mmap X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jun 2009 16:46:05 -0000 On Fri, Jun 05, 2009 at 03:24:09AM +0200, Vladimir 'phcoder' Serbinenko wrote: > > gcc -Icommands -I./commands -I. -I./include -I./include -Wall -W  -Wall -W - > > Wshadow -Wpointer-arith -Wmissing-prototypes                  -Wundef - > > Wstrict-prototypes -g -Os -falign-jumps=1 -falign-loops=1 -falign-functions=1 > > -m32 -fno-stack-protector -mno-stack-arg-probe -fno-builtin -mrtd -mregparm=3 > > -m32 -Werror -Wall -MD -c -o search_mod-commands_search.o commands/search.c > > cc1: warnings being treated as errors > > commands/search.c: In function 'search_fs': > > commands/search.c:42: error: generating trampoline in object (requires > > executable stack) > > commands/search.c: In function 'grub_cmd_search': > > commands/search.c:105: error: generating trampoline in object (requires > > executable stack) > > make[1]: *** [search_mod-commands_search.o] Error 1 > > > > $ gcc --version > > gcc (Gentoo 4.3.3-r2 p1.1, pie-10.1.5) 4.3.3 > > > This is because of commit 2243 by Robert Millan. The commit was about > floppy probing but also added -Wall -Werror to search.mod > I myself stepped on this mine once with adding -Wall -Werror to my xnu module. > I'll revert this change (only -Werror, not the rest of commit) as it > causes build error for all gentoo users. Sorry, Robert, but we can't > enable -Werror and still have nested functions. I don't think we > should use -Werror at all because different compilers, versions or > modifications of same compiler cause different warnings and imho > maintaintaining cost is too high and breaks are too frequent. Or > perhaps we can enable -Werror only on some compilers? Or perhaps > anyone has a better idea Unfixed warnings have given us MUCH worse problems than build failures. I'm talking countless hours of debugging here. Why exactly does gcc generate a warning because of nested functions? Is there no way to fix this? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."