All of lore.kernel.org
 help / color / mirror / Atom feed
From: Riccardo Ghetta <birrachiara@tin.it>
To: romieu@fr.zoreil.com
Cc: netdev@vger.kernel.org
Subject: [PATCH] sis190: fix for x86_64 (bug 11509)
Date: Mon, 8 Jun 2009 07:47:58 +0200	[thread overview]
Message-ID: <20090608054758.GA21975@localhost> (raw)

Corrected dma sync handling on small packets. Should fix 
http://bugzilla.kernel.org/show_bug.cgi?id=11509
Note:
While this bug was reported only on x86_64, it could have affected
any architecture.

Signed-off-by: Riccardo Ghetta <birrachiara@tin.it>
---
 drivers/net/sis190.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c
index f0d73ab..8a98524 100644
--- a/drivers/net/sis190.c
+++ b/drivers/net/sis190.c
@@ -540,8 +540,8 @@ static bool sis190_try_rx_copy(struct sis190_private *tp,
 	if (!skb)
 		goto out;
 
-	pci_dma_sync_single_for_device(tp->pci_dev, addr, pkt_size,
-				       PCI_DMA_FROMDEVICE);
+	pci_dma_sync_single_for_cpu(tp->pci_dev, addr, tp->rx_buf_sz,
+				PCI_DMA_FROMDEVICE);
 	skb_reserve(skb, 2);
 	skb_copy_to_linear_data(skb, sk_buff[0]->data, pkt_size);
 	*sk_buff = skb;
-- 
1.6.2.4


             reply	other threads:[~2009-06-08  5:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-08  5:47 Riccardo Ghetta [this message]
2009-06-08  7:10 ` [PATCH] sis190: fix for x86_64 (bug 11509) David Miller
2009-06-08 16:21   ` r.ghetta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090608054758.GA21975@localhost \
    --to=birrachiara@tin.it \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.