From: Ingo Molnar <mingo@elte.hu>
To: Huang Ying <ying.huang@intel.com>, Steven Rostedt <rostedt@goodmis.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andi Kleen <ak@linux.intel.com>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -v5] x86: MCE: Re-implement MCE log ring buffer as per-CPU ring buffer
Date: Mon, 8 Jun 2009 09:38:45 +0200 [thread overview]
Message-ID: <20090608073845.GA32745@elte.hu> (raw)
In-Reply-To: <1244446222.8361.584.camel@yhuang-dev.sh.intel.com>
* Huang Ying <ying.huang@intel.com> wrote:
> On Mon, 2009-06-08 at 15:20 +0800, Ingo Molnar wrote:
> > * Huang Ying <ying.huang@intel.com> wrote:
> >
> > > Re-implement MCE log ring buffer as per-CPU ring buffer for better
> > > scalability.
> >
> > this should be done using the generic ring-buffer code - see
> > include/linux/ring_buffer.h. Having a private implementation in
> > architecture code is not really acceptable.
>
> MCE log ring buffer need to be NMI-safe, while current generic
> ring-buffer code is not NMI safe. [...]
Then please work with Steve to make it NMI safe (or do so yourself)
- i've Cc:-ed him - that way we help the core kernel: one of its
essential facilities will get one more user. We dont put private,
open-coded ring-buffer facilities into architecture code.
Ingo
next prev parent reply other threads:[~2009-06-08 7:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-08 7:11 [PATCH -v5] x86: MCE: Re-implement MCE log ring buffer as per-CPU ring buffer Huang Ying
2009-06-08 7:20 ` Ingo Molnar
2009-06-08 7:30 ` Huang Ying
2009-06-08 7:38 ` Ingo Molnar [this message]
2009-06-08 8:26 ` Huang Ying
2009-06-08 8:52 ` Ingo Molnar
2009-06-08 12:01 ` Steven Rostedt
2009-06-11 6:43 ` Hidetoshi Seto
2009-06-11 6:48 ` Huang Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090608073845.GA32745@elte.hu \
--to=mingo@elte.hu \
--cc=ak@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=tglx@linutronix.de \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.