From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: dmitry pervushin
<dpervushin-L1vi/lXTdtvkgf6YlCu6wwC/G2K4zDHf@public.gmane.org>
Cc: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH, RFC] Freescale STMP: i2c driver
Date: Tue, 9 Jun 2009 09:46:06 +0200 [thread overview]
Message-ID: <20090609094606.18f04523@hyperion.delvare> (raw)
In-Reply-To: <20090608225034.GA20446-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
On Mon, 8 Jun 2009 23:50:34 +0100, Ben Dooks wrote:
> On Wed, Jun 03, 2009 at 11:59:15PM +0400, dmitry pervushin wrote:
> > +static const u32 I2C_READ = 1,
> > + I2C_WRITE = 0;
>
> do you really want to be defining things with a prefix of I2C, that
> might end up clashing with the i2c core?
Definitely not. Please just use I2C_SMBUS_READ and I2C_SMBUS_WRITE
which are already defined by <linux/i2c.h>.
(One might argue these are unfortunate names, but that's what we have
at the moment so let's just use it.)
--
Jean Delvare
next prev parent reply other threads:[~2009-06-09 7:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-03 19:59 [PATCH, RFC] Freescale STMP: i2c driver dmitry pervushin
[not found] ` <1244059155.4074.19.camel-GL0tbJR47UuzLY3athcO2A@public.gmane.org>
2009-06-08 22:50 ` Ben Dooks
[not found] ` <20090608225034.GA20446-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2009-06-09 7:46 ` Jean Delvare [this message]
2009-06-16 16:25 ` dmitry pervushin
[not found] ` <1245169539.32549.12.camel-GL0tbJR47UuzLY3athcO2A@public.gmane.org>
2009-06-22 10:51 ` Ben Dooks
[not found] ` <20090622105148.GC9006-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2009-06-22 13:41 ` dmitry pervushin
2009-06-15 8:19 ` Ben Dooks
[not found] ` <20090615081938.GA19878-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2009-06-16 16:31 ` dmitry pervushin
[not found] ` <1245169913.32549.19.camel-GL0tbJR47UuzLY3athcO2A@public.gmane.org>
2009-06-22 0:47 ` Ben Dooks
[not found] ` <20090622004741.GB9006-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2009-06-22 13:39 ` dmitry pervushin
2009-06-22 13:42 ` [PATCH, RFC] Freescale STMP: i2c driver, updated with correct signed-off lines dmitry pervushin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090609094606.18f04523@hyperion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=dpervushin-L1vi/lXTdtvkgf6YlCu6wwC/G2K4zDHf@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.