From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Chiang Subject: Re: [PATCH v2 07/11] ACPI: acpi_pci_unbind should clean up properly after acpi_pci_bind Date: Tue, 9 Jun 2009 13:09:11 -0600 Message-ID: <20090609190911.GE23647@ldl.fc.hp.com> References: <20090604054504.18802.21690.stgit@bob.kio> <20090604055852.18802.22743.stgit@bob.kio> <4A2788FA.2050606@jp.fujitsu.com> <20090604233521.GA12900@ethanol> <4A2C8429.2020401@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4A2C8429.2020401@jp.fujitsu.com> Sender: linux-pci-owner@vger.kernel.org To: Kenji Kaneshige Cc: lenb@kernel.org, linux-acpi@vger.kernel.org, Bjorn Helgaas , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org List-Id: linux-acpi@vger.kernel.org * Kenji Kaneshige : > Alex Chiang wrote: >> diff --git a/drivers/acpi/pci_bind.c b/drivers/acpi/pci_bind.c >> index 62cb383..c9cc650 100644 >> --- a/drivers/acpi/pci_bind.c >> +++ b/drivers/acpi/pci_bind.c >> @@ -109,11 +109,13 @@ static int acpi_pci_unbind(struct acpi_device *device) >> struct pci_dev *dev; >> dev = acpi_get_pci_dev(device->handle); >> - if (!dev) >> + if (!dev || !dev->subordinate) >> return 0; > > This would leak the pci_dev's refcount > if dev != NULL && dev->subordinate == NULL. Yes, of course you are correct. Thanks for correcting my sloppiness. Here is the correct fix. From: Alex Chiang ACPI: acpi_pci_unbind should clean up properly after acpi_pci_bind In acpi_pci_bind, we set device->ops.bind and device->ops.unbind, but never clear them out. Cc: Bjorn Helgaas Signed-off-by: Alex Chiang --- diff --git a/drivers/acpi/pci_bind.c b/drivers/acpi/pci_bind.c index 62cb383..af75784 100644 --- a/drivers/acpi/pci_bind.c +++ b/drivers/acpi/pci_bind.c @@ -109,12 +109,15 @@ static int acpi_pci_unbind(struct acpi_device *device) struct pci_dev *dev; dev = acpi_get_pci_dev(device->handle); - if (!dev) - return 0; + if (!dev || !dev->subordinate) + goto out: - if (dev->subordinate) - acpi_pci_irq_del_prt(dev->subordinate); + acpi_pci_irq_del_prt(dev->subordinate); + device->ops.bind = NULL; + device->ops.unbind = NULL; + +out: pci_dev_put(dev); return 0; }