From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Minchan Kim <minchan.kim@gmail.com>, Mel Gorman <mel@csn.ul.ie>,
Christoph Hellwig <hch@infradead.org>,
Rik van Riel <riel@redhat.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Theodore Tso <tytso@mit.edu>,
Mathieu Desnoyers <compudj@krystal.dyndns.org>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
Zhaolei <zhaolei@cn.fujitsu.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Jason Baron <jbaron@redhat.com>,
Jiaying Zhang <jiayingz@google.com>,
Tom Zanussi <tzanussi@gmail.com>,
Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Subject: [PATCH 04/11] tracing: add major and minor tags for print format
Date: Wed, 10 Jun 2009 01:42:10 -0400 [thread overview]
Message-ID: <20090610054253.523693381@goodmis.org> (raw)
In-Reply-To: 20090610054206.510574695@goodmis.org
[-- Attachment #1: 0004-tracing-add-major-and-minor-tags-for-print-format.patch --]
[-- Type: text/plain, Size: 3810 bytes --]
From: Steven Rostedt <srostedt@redhat.com>
Create the tags <major:field> and <minor:field> for trace format prints.
Given a field (should be of type dev_t) these tags will extract the
major or minor number from the field.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
kernel/trace/trace_read_binary.c | 44 +++++++++++++++++++++++++++++++------
1 files changed, 37 insertions(+), 7 deletions(-)
diff --git a/kernel/trace/trace_read_binary.c b/kernel/trace/trace_read_binary.c
index e2cb6c4..a4b5eaa 100644
--- a/kernel/trace/trace_read_binary.c
+++ b/kernel/trace/trace_read_binary.c
@@ -23,7 +23,7 @@ static struct trace_seq buffer;
* COMMAND := <TYPE:FIELD> | <mask:FIELD:DELIM:MASKS> | <sym:FIELD:SYMBOLS> |
* <if:FIELD:TRUE:FALSE> | <ifmask:FIELD:MASK:TRUE:FALSE> |
* <nsec2sec:PRECISION:FIELD> | <nsec2usec:PRECISION:FIELD> |
- * <nsec2msec:PRECISION:FIELD>
+ * <nsec2msec:PRECISION:FIELD> | <major:FIELD> | <minor:FIELD>
* TYPE := int | uint | hex | ptr | string | strarray
* FIELD := defined by the event structure
* MASKS := MASK=NAME,MASKS | MASK=NAME
@@ -59,7 +59,10 @@ static struct trace_seq buffer;
* DELIM will separate the different masks.
* sym : Print out the name of a matching value. This is similar to
* mask, but only one value may print.
- *
+ * major : Given a 'device number' value, this will convert it to its
+ * major number.
+ * minor : Given a 'device number' value, this will convert it to its
+ * minor number.
*/
#define TOK_SIZE 32
@@ -75,6 +78,8 @@ enum field_types {
FIELD_IS_STRING,
FIELD_IS_STRARRAY,
FIELD_IS_HEX,
+ FIELD_IS_MINOR,
+ FIELD_IS_MAJOR,
FIELD_IS_NSEC2SEC,
FIELD_IS_NSEC2USEC,
FIELD_IS_NSEC2MSEC,
@@ -405,6 +410,8 @@ handle_field(struct ftrace_event_call *event,
case FIELD_IS_UINT:
case FIELD_IS_PTR:
case FIELD_IS_HEX:
+ case FIELD_IS_MINOR:
+ case FIELD_IS_MAJOR:
case FIELD_IS_STRING:
case FIELD_IS_STRARRAY:
field = find_field(event, fmt, end - fmt);
@@ -605,6 +612,12 @@ ftrace_initialize_print(struct ftrace_event_call *event, const char *fmt, ...)
else if (strncmp(fmt, "strarray:", 9) == 0)
field_type = FIELD_IS_STRARRAY;
+ else if (strncmp(fmt, "major:", 6) == 0)
+ field_type = FIELD_IS_MAJOR;
+
+ else if (strncmp(fmt, "minor:", 6) == 0)
+ field_type = FIELD_IS_MINOR;
+
else
goto err_format;
@@ -758,6 +771,8 @@ ftrace_read_binary(struct trace_seq *s, struct ftrace_event_call *event,
case FIELD_IS_UINT:
case FIELD_IS_HEX:
case FIELD_IS_PTR:
+ case FIELD_IS_MAJOR:
+ case FIELD_IS_MINOR:
field = info->data.field;
goto skip_if;
@@ -775,8 +790,9 @@ ftrace_read_binary(struct trace_seq *s, struct ftrace_event_call *event,
return start;
}
- if (info->type == FIELD_IS_IF ||
- info->type == FIELD_IS_IFMASK) {
+ switch (info->type) {
+ case FIELD_IS_IF:
+ case FIELD_IS_IFMASK:
if (info->type == FIELD_IS_IFMASK)
val &= info->cond.mask;
@@ -789,11 +805,25 @@ ftrace_read_binary(struct trace_seq *s, struct ftrace_event_call *event,
trace_seq_putmem(s, event->print_text +
info->cond.false_text,
info->cond.false_len);
- } else if (info->type == FIELD_IS_INT)
+ break;
+
+ case FIELD_IS_INT:
trace_seq_printf(s, "%lld", val);
- else if (info->type == FIELD_IS_UINT)
+ break;
+
+ case FIELD_IS_UINT:
trace_seq_printf(s, "%llu", val);
- else {
+ break;
+
+ case FIELD_IS_MAJOR:
+ trace_seq_printf(s, "%u", MAJOR(val));
+ break;
+
+ case FIELD_IS_MINOR:
+ trace_seq_printf(s, "%u", MINOR(val));
+ break;
+
+ default:
/* hex should only print the size specified */
if (mask)
val &= mask;
--
1.6.3.1
--
next prev parent reply other threads:[~2009-06-10 5:44 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-10 5:42 [PATCH 00/11] [GIT PULL] more updates for the tag format Steven Rostedt
2009-06-10 5:42 ` [PATCH 01/11] tracing/events: convert block trace points to TRACE_EVENT(), fix Steven Rostedt
2009-06-10 5:42 ` [PATCH 02/11] tracing: add nsec2sec print formats Steven Rostedt
2009-06-10 5:42 ` [PATCH 03/11] tracing: convert lockdep lock_acquired trace point to use nsec2usec tag Steven Rostedt
2009-06-10 5:42 ` Steven Rostedt [this message]
2009-06-10 5:42 ` [PATCH 05/11] tracing: use << to print < instead of \< Steven Rostedt
2009-06-10 5:42 ` [PATCH 06/11] tracing: convert the block trace points to use the new tag format Steven Rostedt
2009-06-10 5:42 ` [PATCH 07/11] tracing: add test for strings in event " Steven Rostedt
2009-06-10 5:42 ` [PATCH 08/11] tracing: add func and symfunc to " Steven Rostedt
2009-06-10 7:48 ` Frederic Weisbecker
2009-06-10 12:55 ` Steven Rostedt
2009-06-10 5:42 ` [PATCH 09/11] tracing: check full name for field Steven Rostedt
2009-06-10 5:42 ` [PATCH 10/11] tracing: update sample code with new tag format Steven Rostedt
2009-06-10 5:42 ` [PATCH 11/11] tracing: move > to out of macros and into print statement Steven Rostedt
2009-06-10 9:26 ` [PATCH 00/11] [GIT PULL] more updates for the tag format Ingo Molnar
2009-06-10 11:11 ` Frédéric Weisbecker
2009-06-10 13:01 ` Theodore Tso
2009-06-10 13:49 ` Steven Rostedt
2009-06-10 14:39 ` Mathieu Desnoyers
2009-06-10 15:21 ` Steven Rostedt
2009-06-10 16:03 ` Theodore Tso
2009-06-10 16:17 ` Steven Rostedt
2009-06-11 13:03 ` Christoph Hellwig
2009-06-11 15:47 ` Theodore Tso
2009-06-11 17:14 ` Frederic Weisbecker
2009-06-11 19:20 ` Theodore Tso
2009-06-19 8:14 ` [BUG] bugs in jbd2_dev_to_name() (was Re: [PATCH 00/11] [GIT PULL] more updates for the tag format) Li Zefan
2009-06-19 12:32 ` Theodore Tso
2009-06-22 1:36 ` Li Zefan
2009-06-22 1:36 ` Li Zefan
-- strict thread matches above, loose matches on Subject: below --
2009-06-10 16:53 [PATCH 00/11] [GIT PULL][for 2.6.32] new event print tag language Steven Rostedt
2009-06-10 16:53 ` [PATCH 04/11] tracing: add major and minor tags for print format Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090610054253.523693381@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=compudj@krystal.dyndns.org \
--cc=fweisbec@gmail.com \
--cc=hch@infradead.org \
--cc=jbaron@redhat.com \
--cc=jiayingz@google.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=tytso@mit.edu \
--cc=tzanussi@gmail.com \
--cc=xiaoguangrong@cn.fujitsu.com \
--cc=zhaolei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.