From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758786AbZFJFpz (ORCPT ); Wed, 10 Jun 2009 01:45:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755935AbZFJFnB (ORCPT ); Wed, 10 Jun 2009 01:43:01 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.123]:45704 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755457AbZFJFmx (ORCPT ); Wed, 10 Jun 2009 01:42:53 -0400 Message-Id: <20090610054255.029219112@goodmis.org> References: <20090610054206.510574695@goodmis.org> User-Agent: quilt/0.46-1 Date: Wed, 10 Jun 2009 01:42:17 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Ingo Molnar , Andrew Morton , Minchan Kim , Mel Gorman , Christoph Hellwig , Rik van Riel , Pekka Enberg , Peter Zijlstra , Frederic Weisbecker , Theodore Tso , Mathieu Desnoyers , Lai Jiangshan , Zhaolei , KOSAKI Motohiro , Jason Baron , Jiaying Zhang , Tom Zanussi , Xiao Guangrong Subject: [PATCH 11/11] tracing: move > to out of macros and into print statement Content-Disposition: inline; filename=0011-tracing-move-to-out-of-macros-and-into-print-stateme.patch Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Steven Rostedt Frederic Weisbecker stated that it is confusing to see a unmatched '<', when the '>' is hidden inside a macro. This patch moves it out back to the string. Reported-by: Frederic Weisbecker Signed-off-by: Steven Rostedt --- include/trace/events/irq.h | 8 +++++--- include/trace/events/kmem.h | 12 +++++++----- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/include/trace/events/irq.h b/include/trace/events/irq.h index c6c0ff1..4294a6d 100644 --- a/include/trace/events/irq.h +++ b/include/trace/events/irq.h @@ -9,7 +9,7 @@ #define softirq_name(sirq) sirq##_SOFTIRQ, #sirq #define show_softirq_name_format(val) \ - "%d=%s,%d=%s,%d=%s,%d=%s,%d=%s,%d=%s,%d=%s,%d=%s,%d=%s>" + "%d=%s,%d=%s,%d=%s,%d=%s,%d=%s,%d=%s,%d=%s,%d=%s,%d=%s" #define show_softirq_name_args() \ softirq_name(HI), \ softirq_name(TIMER), \ @@ -106,7 +106,8 @@ TRACE_EVENT(softirq_entry, __entry->vec = (int)(h - vec); ), - TP_FORMAT("softirq= action= action=", show_softirq_name_args()) ); @@ -135,7 +136,8 @@ TRACE_EVENT(softirq_exit, __entry->vec = (int)(h - vec); ), - TP_FORMAT("softirq= action= action=", show_softirq_name_args()) ); diff --git a/include/trace/events/kmem.h b/include/trace/events/kmem.h index 5c8f942..32c93da 100644 --- a/include/trace/events/kmem.h +++ b/include/trace/events/kmem.h @@ -22,7 +22,7 @@ "0x%lx=%s,0x%lx=%s,0x%lx=%s,0x%lx=%s,0x%lx=%s,0x%lx=%s,0x%lx=%s," \ "0x%lx=%s,0x%lx=%s,0x%lx=%s,0x%lx=%s,0x%lx=%s,0x%lx=%s,0x%lx=%s," \ "0x%lx=%s,0x%lx=%s,0x%lx=%s,0x%lx=%s,0x%lx=%s,0x%lx=%s,0x%lx=%s," \ - "0x%lx=%s,0x%lx=%s>" + "0x%lx=%s,0x%lx=%s" #define show_gfp_flags_args() \ (unsigned long)GFP_HIGHUSER_MOVABLE, "GFP_HIGHUSER_MOVABLE", \ (unsigned long)GFP_HIGHUSER, "GFP_HIGHUSER", \ @@ -76,7 +76,7 @@ TRACE_EVENT(kmalloc, TP_FORMAT("call_site= ptr= bytes_req= " "bytes_alloc= gfp_flags=", show_gfp_flags_args()) ); TRACE_EVENT(kmem_cache_alloc, @@ -107,7 +107,7 @@ TRACE_EVENT(kmem_cache_alloc, TP_FORMAT("call_site= ptr= bytes_req= " "bytes_alloc= gfp_flags=", show_gfp_flags_args()) ); TRACE_EVENT(kmalloc_node, @@ -141,7 +141,8 @@ TRACE_EVENT(kmalloc_node, TP_FORMAT("call_site= ptr= bytes_req= " "bytes_alloc= gfp_flags=", show_gfp_flags_args()) + show_gfp_flags_format() "> node=", + show_gfp_flags_args()) ); TRACE_EVENT(kmem_cache_alloc_node, @@ -175,7 +176,8 @@ TRACE_EVENT(kmem_cache_alloc_node, TP_FORMAT("call_site= ptr= bytes_req= " "bytes_alloc= gfp_flags=", show_gfp_flags_args()) + show_gfp_flags_format() "> node=", + show_gfp_flags_args()) ); TRACE_EVENT(kfree, -- 1.6.3.1 --