From: Matt Fleming <matt@console-pimps.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: Fix sh4a llsc operation
Date: Wed, 10 Jun 2009 15:54:52 +0000 [thread overview]
Message-ID: <20090610155452.GA5554@console-pimps.org> (raw)
In-Reply-To: <4A2FD353.5080201@gmail.com>
On Thu, Jun 11, 2009 at 12:37:55AM +0900, Aoi Shinkai wrote:
> This patch fixes sh4a llsc operation.
> Most of all is taken from arm and mips.
>
> Signed-off-by: Aoi Shinkai <shinkoi2005@gmail.com>
[...]
> diff --git a/arch/sh/include/asm/cmpxchg-llsc.h b/arch/sh/include/asm/cmpxchg-llsc.h
> index 0fac3da..4713666 100644
> --- a/arch/sh/include/asm/cmpxchg-llsc.h
> +++ b/arch/sh/include/asm/cmpxchg-llsc.h
> @@ -55,7 +55,7 @@ __cmpxchg_u32(volatile int *m, unsigned long old, unsigned long new)
> "mov %0, %1 \n\t"
> "cmp/eq %1, %3 \n\t"
> "bf 2f \n\t"
> - "mov %3, %0 \n\t"
> + "mov %4, %0 \n\t"
> "2: \n\t"
> "movco.l %0, @%2 \n\t"
> "bf 1b \n\t"
Good catch!
> diff --git a/arch/sh/include/asm/spinlock.h b/arch/sh/include/asm/spinlock.h
> index 6028356..69f4dc7 100644
> --- a/arch/sh/include/asm/spinlock.h
> +++ b/arch/sh/include/asm/spinlock.h
> @@ -26,7 +26,7 @@
> #define __raw_spin_is_locked(x) ((x)->lock <= 0)
> #define __raw_spin_lock_flags(lock, flags) __raw_spin_lock(lock)
> #define __raw_spin_unlock_wait(x) \
> - do { cpu_relax(); } while ((x)->lock)
> + do { while (__raw_spin_is_locked(lock)) cpu_relax(); } while (0)
>
> /*
> * Simple spin lock operations. There are two variants, one clears IRQ's
That looks like a pasting error to me, "lock" should be "x".
next prev parent reply other threads:[~2009-06-10 15:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-10 15:37 [PATCH] sh: Fix sh4a llsc operation Aoi Shinkai
2009-06-10 15:54 ` Matt Fleming [this message]
2009-06-10 16:15 ` Aoi Shinkai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090610155452.GA5554@console-pimps.org \
--to=matt@console-pimps.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.