Re: [Qemu-devel] [PATCH 4/7] target-ppc: retain l{w,d}arx loaded value

[Riku Voipio <riku.voipio@iki.fi>]

Not that I can really review this patch, but;

On Thu, Jun 04, 2009 at 11:51:59AM -0700, Nathan Froyd wrote:
>  GEN_HANDLER(ldarx, 0x1F, 0x14, 0x02, 0x00000001, PPC_64B)
>  {
>      TCGv t0;
> +    TCGv gpr = cpu_gpr[rD(ctx->opcode)];
>      gen_set_access_type(ctx, ACCESS_RES);
>      t0 = tcg_temp_local_new();
>      gen_addr_reg_index(ctx, t0);
>      gen_check_align(ctx, t0, 0x07);
> -    gen_qemu_ld64(ctx, cpu_gpr[rD(ctx->opcode)], t0);
> +    gen_qemu_ld64(ctx, gpr, t0);
>      tcg_gen_mov_tl(cpu_reserve, t0);
> +    tcg_gen_st_tl(gpr, cpu_env, offsetof(CPUState, reserve_val);

missing a closing parens?

>      tcg_temp_free(t0);
>  }