All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Dilger <adilger@sun.com>
To: Howard Cochran <hcochran@lexmark.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: Kernel thread to zero itables for lazy_itable_init?
Date: Wed, 10 Jun 2009 23:37:56 -0600	[thread overview]
Message-ID: <20090611053756.GQ9002@webber.adilger.int> (raw)
In-Reply-To: <4A303692.3010104@lpdev.prtdev.lexmark.com>

On Jun 10, 2009  18:41 -0400, Howard Cochran wrote:
> What is the status of the code to start a background kernel thread to  
> zero the inode tables when filesystem that was created with mke2fs -E  
> lazy_itable_init is mounted?  All I have found is a patch set posted to  
> this mailing list back on November 21, 2008 and some discussion of the  
> implementation, but nothing after that.
>
> Is this effort still alive?

I don't think anyone is currently working on it.

> On a related note, from what I have read here, and from looking at the  
> ext4 kernel code, the filesystem itself never really requires the inode  
> tables to be zeroed out.  The only reason one might want to do that is  
> so that fsck does not detect false errors. 

Correct, but the risk is that the whole filesystem could become corrupted
by the old data in the inode table.

> So, I am wondering whether we really need the complexity of a kernel  
> thread to zero out the itable (or the long delay of doing it during  
> mke2fs).  Instead, would it not be better to modify fsck to ignore  
> garbage in unallocated inodes, at least for filesystems that have a 
> journal.

Sure, e2fsck already does that, but this is not totally robust.  If
the marker for unallocated inodes itself becomes corrupted (which
will happen eventually, or e2fsck wouldn't ever be needed) then the
aforementioned filesystem-wide corruption could ensue.

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.


      reply	other threads:[~2009-06-11  5:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-10 22:41 Kernel thread to zero itables for lazy_itable_init? Howard Cochran
2009-06-11  5:37 ` Andreas Dilger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090611053756.GQ9002@webber.adilger.int \
    --to=adilger@sun.com \
    --cc=hcochran@lexmark.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.