All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org, Mark McLoughlin <markmc@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Alex Williamson <alex.williamson@hp.com>
Subject: Re: [Qemu-devel] Re: Networking patches queue
Date: Thu, 11 Jun 2009 12:48:21 +0100	[thread overview]
Message-ID: <200906111248.22091.paul@codesourcery.com> (raw)
In-Reply-To: <1244583818.7164.19.camel@blaa>

On Tuesday 09 June 2009, Mark McLoughlin wrote:
>       net: add return value to packet receive handler (4f1c942b7f)

This patch is wrong. We already have a can_receive handler for this purpose.  
Having this callback and allowing receive to fail is just silly. One or the 
other, but not both.

Paul

  parent reply	other threads:[~2009-06-11 11:48 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-28 15:19 [Qemu-devel] Networking patches queue Mark McLoughlin
2009-05-28 15:28 ` [Qemu-devel] " Anthony Liguori
2009-05-28 15:51   ` Jan Kiszka
2009-05-28 16:57     ` Mark McLoughlin
2009-05-28 20:26       ` Anthony Liguori
2009-05-28 17:01     ` Glauber Costa
2009-05-28 17:19       ` Jan Kiszka
2009-05-28 19:10       ` Jan Kiszka
2009-05-28 15:51   ` Mark McLoughlin
2009-05-28 15:56     ` Anthony Liguori
2009-05-28 16:52       ` Mark McLoughlin
2009-05-31 20:58       ` Dor Laor
2009-06-09 21:43 ` Mark McLoughlin
2009-06-10 23:08   ` Anthony Liguori
2009-06-11  1:27   ` Anthony Liguori
2009-06-11  8:34     ` Mark McLoughlin
2009-06-11  8:38   ` Gerd Hoffmann
2009-06-11  9:42     ` [Qemu-devel] [PATCH] Fix xilinx_ethlite breakage by 4f1c942b7f Jan Kiszka
2009-06-11 10:48       ` [Qemu-devel] " Mark McLoughlin
2009-06-11 11:48   ` Paul Brook [this message]
2009-06-11 12:50     ` [Qemu-devel] Re: Networking patches queue Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906111248.22091.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=alex.williamson@hp.com \
    --cc=aliguori@us.ibm.com \
    --cc=jan.kiszka@siemens.com \
    --cc=markmc@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.