All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [RFC] Enable Werrror by default
Date: Thu, 11 Jun 2009 13:35:09 +0100	[thread overview]
Message-ID: <200906111335.10116.paul@codesourcery.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

I'd like to enable Werror by default. I've been using --enable-werror locally 
for a while now, and it's been extremely useful in picking up dumb errors 
(like the recent stellaris_enet.c breakage).

Any objections?

You can of course configure with --disable-werror if you really want the force 
things to build.

Paul

[-- Attachment #2: 0001-Enable-Werror-by-default.patch --]
[-- Type: text/x-patch, Size: 771 bytes --]

From 5ccaebfce38fc161a776725c6c945b2173459397 Mon Sep 17 00:00:00 2001
From: Paul Brook <paul@codesourcery.com>
Date: Thu, 11 Jun 2009 13:31:46 +0100
Subject: [PATCH] Enable Werror by default

Signed-off-by: Paul Brook <paul@codesourcery.com>
---
 configure |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/configure b/configure
index 89e7f53..9e03ee3 100755
--- a/configure
+++ b/configure
@@ -356,11 +356,7 @@ else
 fi
 [ -f "$workdir/vl.c" ] || source_path_used="yes"
 
-werror="no"
-# generate compile errors on warnings for development builds
-#if grep cvs $source_path/VERSION > /dev/null 2>&1 ; then
-#werror="yes";
-#fi
+werror="yes"
 
 for opt do
   optarg=`expr "x$opt" : 'x[^=]*=\(.*\)'`
-- 
1.6.3.1


             reply	other threads:[~2009-06-11 12:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-11 12:35 Paul Brook [this message]
2009-06-11 12:46 ` [Qemu-devel] [RFC] Enable Werrror by default Tristan Gingold
2009-06-11 13:10   ` Christoph Egger
2009-06-11 14:02   ` Andreas Färber
2009-06-11 12:58 ` Anthony Liguori
2009-06-11 13:14 ` Mark McLoughlin
2009-06-11 13:34   ` Christoph Egger
2009-06-11 13:35   ` Paul Brook
2009-06-11 14:20   ` Richard W.M. Jones
2009-06-11 18:30   ` Anthony Liguori
2009-06-11 18:38     ` Mark McLoughlin
2009-06-11 20:03       ` Anthony Liguori
2009-06-11 22:28     ` Paul Brook
2009-06-11 15:18 ` David Turner
2009-06-11 17:24   ` Stuart Brady

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906111335.10116.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.