From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760928AbZFLPpv (ORCPT ); Fri, 12 Jun 2009 11:45:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752718AbZFLPpn (ORCPT ); Fri, 12 Jun 2009 11:45:43 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:34529 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752527AbZFLPpn (ORCPT ); Fri, 12 Jun 2009 11:45:43 -0400 Date: Fri, 12 Jun 2009 17:45:25 +0200 From: Ingo Molnar To: Wu Fengguang Cc: Thomas Gleixner , "H. Peter Anvin" , Peter Zijlstra , Andrew Morton , LKML , Nick Piggin , Hugh Dickins , Andi Kleen , "riel@redhat.com" , "chris.mason@oracle.com" , "linux-mm@kvack.org" , Linus Torvalds Subject: Re: [PATCH 1/5] HWPOISON: define VM_FAULT_HWPOISON to 0 when feature is disabled Message-ID: <20090612154525.GA14438@elte.hu> References: <20090611142239.192891591@intel.com> <20090611144430.414445947@intel.com> <20090612112258.GA14123@elte.hu> <20090612125741.GA6140@localhost> <20090612131754.GA32105@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090612131754.GA32105@elte.hu> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Ingo Molnar wrote: > So i find the whole feature rather dubious - what's the point? We > should panic at this point - we just corrupted user data so that > piece of hardware cannot be trusted. Nor can any subsequent kernel > bug messages be trusted. s/panic/print nasty message Not sure what i was smoking there. Sysadmin will panic from a memory corruption message anyway. What feels wrong to me is: kill a process and - in the case where that process is restartable or expendable - suggest to the admin that "everything is fine, we handled it just fine". Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with ESMTP id 0A8C46B009A for ; Fri, 12 Jun 2009 11:44:10 -0400 (EDT) Date: Fri, 12 Jun 2009 17:45:25 +0200 From: Ingo Molnar Subject: Re: [PATCH 1/5] HWPOISON: define VM_FAULT_HWPOISON to 0 when feature is disabled Message-ID: <20090612154525.GA14438@elte.hu> References: <20090611142239.192891591@intel.com> <20090611144430.414445947@intel.com> <20090612112258.GA14123@elte.hu> <20090612125741.GA6140@localhost> <20090612131754.GA32105@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090612131754.GA32105@elte.hu> Sender: owner-linux-mm@kvack.org To: Wu Fengguang Cc: Thomas Gleixner , "H. Peter Anvin" , Peter Zijlstra , Andrew Morton , LKML , Nick Piggin , Hugh Dickins , Andi Kleen , "riel@redhat.com" , "chris.mason@oracle.com" , "linux-mm@kvack.org" , Linus Torvalds List-ID: * Ingo Molnar wrote: > So i find the whole feature rather dubious - what's the point? We > should panic at this point - we just corrupted user data so that > piece of hardware cannot be trusted. Nor can any subsequent kernel > bug messages be trusted. s/panic/print nasty message Not sure what i was smoking there. Sysadmin will panic from a memory corruption message anyway. What feels wrong to me is: kill a process and - in the case where that process is restartable or expendable - suggest to the admin that "everything is fine, we handled it just fine". Ingo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org