All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-kernel@vger.kernel.org, Michael Chan <mchan@broadcom.com>,
	"David S. Miller" <davem@davemloft.net>,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: -git tree build failure #2: drivers/net/cnic.c:2520: error: implicit declaration of function ‘__symbol_get’
Date: Sat, 13 Jun 2009 08:29:33 +0200	[thread overview]
Message-ID: <20090613062933.GA14034@elte.hu> (raw)
In-Reply-To: <4A32A1E4.8080708@oracle.com>


* Randy Dunlap <randy.dunlap@oracle.com> wrote:

> Ingo Molnar wrote:
> > today's -git fails to build with ipv6 disabled (x86):
> > 
> >   drivers/built-in.o: In function `cnic_get_v6_route':
> >   cnic.c:(.text+0x104c42): undefined reference to `ip6_route_output'
> > 
> > introduced by this new driver:
> > 
> >   a463696: [SCSI] cnic: Add new Broadcom CNIC driver.
> 
> I just posted a patch for this to netdev and it was acked by its maintainer.
> Patch is below.

This solves the first build failure but there's still a second build 
failure:

 drivers/net/cnic.c: In function ‘init_bnx2_cnic’:
 drivers/net/cnic.c:2520: error: implicit declaration of function ‘__symbol_get’
 drivers/net/cnic.c:2520: warning: assignment makes pointer from integer without a cast
 make[1]: *** [drivers/net/cnic.o] Error 1
 make: *** [drivers/net/cnic.o] Error 2

This too triggers with the config i sent. The patch below solves it 
- but i havent done more testing.

	Ingo

Signed-off-by: Ingo Molnar <mingo@elte.hu>

diff --git a/drivers/net/cnic.c b/drivers/net/cnic.c
index 8d74037..49135cc 100644
--- a/drivers/net/cnic.c
+++ b/drivers/net/cnic.c
@@ -25,6 +25,8 @@
 #include <linux/delay.h>
 #include <linux/ethtool.h>
 #include <linux/if_vlan.h>
+#include <linux/module.h>
+
 #if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)
 #define BCM_VLAN 1
 #endif

  parent reply	other threads:[~2009-06-13  6:29 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-12 18:43 -git tree build failure in drivers/net/cnic.c: undefined reference to `ip6_route_output' Ingo Molnar
2009-06-12 18:43 ` Randy Dunlap
2009-06-12 23:51   ` David Miller
2009-06-13  0:03     ` James Bottomley
2009-06-13  0:05       ` David Miller
2009-06-13 14:37         ` James Bottomley
2009-06-13  6:42       ` Ingo Molnar
2009-06-13  7:03         ` Michael Chan
2009-06-13  6:29   ` Ingo Molnar [this message]
2009-06-13 20:11     ` -git tree build failure #2: drivers/net/cnic.c:2520: error: implicit declaration of function ‘__symbol_get’ Linus Torvalds
2009-06-13 20:31       ` Ingo Molnar
2009-06-13 20:35         ` Ingo Molnar
2009-06-13 20:46           ` Ingo Molnar
2009-06-13 20:42       ` James Bottomley
2009-06-14  0:43         ` Michael Chan
2009-06-14  1:33           ` James Bottomley
2009-06-14  2:18             ` Michael Chan
2009-06-14 14:15               ` James Bottomley
2009-06-14 14:51                 ` -git tree build failure #2: drivers/net/cnic.c:2520: error: implicit declaration of function '__symbol_get' Michael Chan
2009-06-15  1:27             ` -git tree build failure #2: drivers/net/cnic.c:2520: error: implicit declaration of function ‘__symbol_get’ Mike Christie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090613062933.GA14034@elte.hu \
    --to=mingo@elte.hu \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchan@broadcom.com \
    --cc=randy.dunlap@oracle.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.