All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Paul Mackerras <paulus@samba.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: perf_counters: page fault trace record
Date: Sat, 13 Jun 2009 09:04:11 +0200	[thread overview]
Message-ID: <20090613070411.GA6682@elte.hu> (raw)
In-Reply-To: <18995.8319.322002.917595@cargo.ozlabs.ibm.com>


* Paul Mackerras <paulus@samba.org> wrote:

> Corey Ashford writes:
> 
> > One of the tools we are working on needs to be able to look not only at counts 
> > of page faults, but where they are occurring (ip and faulting page address).
> > 
> > What would you think about adding a new bit to the config record, something like:
> 
> Can't you do what you need just using a page fault software 
> counter with sample_type = PERF_SAMPLE_IP | PERF_SAMPLE_ADDR and 
> sample_period = 1?

Yes, we should use a generic 'data address' field. A whole lot of 
interesting events can live with that - only full-blown generic 
tracepoints have more complex sample record formats.

Also, if this feature is added to pagefaults, please also add 
support for it into tools/perf/, so that it gets tested/used.

Thanks,

	Ingo

  reply	other threads:[~2009-06-13  7:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-13  1:25 perf_counters: page fault trace record Corey Ashford
2009-06-13  3:43 ` Paul Mackerras
2009-06-13  7:04   ` Ingo Molnar [this message]
2009-06-13  8:44   ` Corey Ashford
2009-06-13  9:17     ` Paul Mackerras
2009-06-13 10:09       ` Ingo Molnar
2009-06-15 20:38         ` Corey Ashford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090613070411.GA6682@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=cjashfor@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.