From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org, Mike Travis <travis@sgi.com>
Subject: Re: [PATCH 1/13] cpumask: Use accessors for cpu_*_mask: arm
Date: Sat, 13 Jun 2009 14:49:22 +0100 [thread overview]
Message-ID: <20090613134922.GA23433@flint.arm.linux.org.uk> (raw)
In-Reply-To: <200906132225.12855.rusty@rustcorp.com.au>
On Sat, Jun 13, 2009 at 10:25:12PM +0930, Rusty Russell wrote:
> On Sat, 13 Jun 2009 04:33:03 am Russell King wrote:
> > On Fri, Jun 12, 2009 at 10:33:14PM +0930, Rusty Russell wrote:
> > > Use the accessors rather than frobbing bits directly (the new versions
> > > are const).
> >
> > Please check linux-next - there are all kinds of SMP changes currently
> > queued up in the ARM tree, which include most of the updates for things
> > like this.
>
> OK, here's the revision based on latest linux-next, if you wouldn't mind
> taking it. (We should really make on_each_cpu_mask an arch-indep, too).
Hmm, weird. Your diff is against does not correspond with my tree, which
supposedly is in linux-next.
Commit 8266810 "[ARM] smp: fix cpumask usage in ARM SMP code" (in my tree
since May 17th) fixes some of the areas which your patch touches. See:
http://ftp.arm.linux.org.uk/git/gitweb.cgi?p=linux-2.6-arm.git;a=shortlog;h=refs/heads/smp
I suggest hanging fire on this until the ARM tree is merged into mainline.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2009-06-13 13:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 13:03 [PATCH 1/13] cpumask: Use accessors for cpu_*_mask: arm Rusty Russell
2009-06-12 19:03 ` Russell King
2009-06-13 12:55 ` Rusty Russell
2009-06-13 13:49 ` Russell King [this message]
2009-06-15 7:44 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090613134922.GA23433@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.