From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>
Subject: [Qemu-devel] Re: [Qemu-commits] [COMMIT 95bed64] Fix a warning: uint_fast8_t is not 8 bits onOpenBSD/Sparc64
Date: Sat, 13 Jun 2009 19:53:24 +0100 [thread overview]
Message-ID: <200906131953.24749.paul@codesourcery.com> (raw)
In-Reply-To: <f43fc5580906131031w4e144ca9l31451a0e5970e86b@mail.gmail.com>
> > > + asid = env->tlb->mmu.r4k.tlb[i].ASID;
> > > + qemu_put_8s(f, &asid);
> >
> > Wouldn't it be simpler to just use qemu_put_byte?
>
> uint_fast8_t equals uint32_t on OpenBSD/Sparc64. It's also big endian,
> so qemu_put_byte(f, &env->tlb->mmu.r4k.tlb[i].ASID) writes the MSB
> (==0).
Not even close. qemu_put_byte works by value, not by reference. i.e. you want
qemu_put_byte(f, env->tlb->mmu.r4k.tlb[i].ASID);
Paul
parent reply other threads:[~2009-06-13 18:53 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <f43fc5580906131031w4e144ca9l31451a0e5970e86b@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906131953.24749.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.