From: Frederic Weisbecker <fweisbec@gmail.com>
To: Wu Zhangjin <wuzhangjin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Linux-MIPS <linux-mips@linux-mips.org>,
Steven Rostedt <rostedt@goodmis.org>,
Ralf Baechle <ralf@linux-mips.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Wu Zhangjin <wuzj@lemote.com>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] tracing: fix undeclared 'PAGE_SIZE' in include/linux/trace_seq.h
Date: Sun, 14 Jun 2009 14:34:52 +0200 [thread overview]
Message-ID: <20090614123451.GA6039@nowhere> (raw)
In-Reply-To: <1244962350-28702-1-git-send-email-wuzhangjin@gmail.com>
On Sun, Jun 14, 2009 at 02:52:30PM +0800, Wu Zhangjin wrote:
> From: Wu Zhangjin <wuzj@lemote.com>
>
> when compiling linux-mips with kmemtrace enabled, there will be an
> error:
>
> include/linux/trace_seq.h:12: error: 'PAGE_SIZE' undeclared here (not in
> a function)
>
> I checked the source code and found trace_seq.h used PAGE_SIZE but not
> included the relative header file, so, fix it via adding the header file
> <asm/page.h>
>
> Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
> Signed-off-by: Wu Zhangjin <wuzj@lemote.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
> ---
> include/linux/trace_seq.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/trace_seq.h b/include/linux/trace_seq.h
> index c68bccb..c134dd1 100644
> --- a/include/linux/trace_seq.h
> +++ b/include/linux/trace_seq.h
> @@ -3,6 +3,8 @@
>
> #include <linux/fs.h>
>
> +#include <asm/page.h>
> +
> /*
> * Trace sequences are used to allow a function to call several other functions
> * to create a string of data to use (up to a max of PAGE_SIZE.
> --
> 1.6.0.4
>
next prev parent reply other threads:[~2009-06-14 12:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-14 6:52 [PATCH] tracing: fix undeclared 'PAGE_SIZE' in include/linux/trace_seq.h Wu Zhangjin
2009-06-14 12:34 ` Frederic Weisbecker [this message]
2009-06-15 18:13 ` [tip:tracing/urgent] " tip-bot for Wu Zhangjin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090614123451.GA6039@nowhere \
--to=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
--cc=ralf@linux-mips.org \
--cc=rostedt@goodmis.org \
--cc=wuzhangjin@gmail.com \
--cc=wuzj@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.