From: Arjan van de Ven <arjan@infradead.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Subject: Re: [PATCH] WARN(): add a \n to the message printk
Date: Mon, 15 Jun 2009 07:13:06 -0700 [thread overview]
Message-ID: <20090615071306.5656aaa0@infradead.org> (raw)
In-Reply-To: <20090615100951.1571bf03@lxorguk.ukuu.org.uk>
On Mon, 15 Jun 2009 10:09:51 +0100
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> > + if (args) {
> > vprintk(args->fmt, args->args);
> > + printk("\n");
>
> What stops another printk occuring between those two ?
>
absolutely nothing... and in that case you get what you get in a
million other places in the kernel; a bit of a mix.
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
next prev parent reply other threads:[~2009-06-15 14:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-15 7:08 [PATCH] WARN(): add a \n to the message printk Arjan van de Ven
2009-06-15 9:09 ` Alan Cox
2009-06-15 14:13 ` Arjan van de Ven [this message]
2009-06-15 16:38 ` Linus Torvalds
2009-06-15 16:58 ` Linus Torvalds
2009-06-15 17:10 ` Ingo Molnar
2009-06-16 4:04 ` Linus Torvalds
2009-06-16 4:16 ` Linus Torvalds
2009-06-16 5:46 ` Arjan van de Ven
2009-06-15 17:57 ` Linus Torvalds
2009-06-15 18:39 ` Ingo Molnar
2009-06-15 18:53 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090615071306.5656aaa0@infradead.org \
--to=arjan@infradead.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.