From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [patch 11/16] xend: pass-through: Move pciconversionfunctions to pci.py Date: Mon, 15 Jun 2009 19:04:49 +1000 Message-ID: <20090615090445.GA14487@verge.net.au> References: <20090615015515.927085604@vergenet.net> <20090615015912.912200267@vergenet.net> <9BC9ED7E454F31kanno.masaki@jp.fujitsu.com> <20090615061559.GA15006@verge.net.au> <9CC9ED8731C4E5kanno.masaki@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <9CC9ED8731C4E5kanno.masaki@jp.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Masaki Kanno Cc: xen-devel@lists.xensource.com, Dexuan Cui List-Id: xen-devel@lists.xenproject.org On Mon, Jun 15, 2009 at 04:02:06PM +0900, Masaki Kanno wrote: > Hi Simon, > > Mon, 15 Jun 2009 16:15:59 +1000, Simon Horman wrote: > > >On Mon, Jun 15, 2009 at 02:58:14PM +0900, Masaki Kanno wrote: > >Content-Description: Mail message body > >> Hi Simon, > >> > >> dev_dict_to_sxp method in XendConfig.py is called for both pci > >> devices and vscsi devices. So, I think that the method should > >> be not moved to pci.py. > >> > >> I suggest separating the processing of pci devices and the > >> processing of vscsi devices in all_devices_sxpr method. > >> I attach a patch for separating them. > > > >That seems reasonable. > > > >I haven't had time to work through the vscsi, nor am I likely to in the > >near future. But does the logic in dev_dict_to_sxp() make sense for vscsi? > > Yes. I confirmed that dev_dict_to_sxp method is working for vscsi. > > > >If so, would you be happy it we moved it somewhere else, perhaps > >into sxp.py? Or create XendSXPDev.py? > > XendSXPDev.py ... Ok, will do.