From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
Cc: Linux Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>
Subject: [PATCH 1/1] fix -ESRCH on self-restart
Date: Mon, 15 Jun 2009 15:20:22 -0500 [thread overview]
Message-ID: <20090615202022.GA18223@us.ibm.com> (raw)
when doing a self-restart, we can't search for ourselves on our
list of children...
Signed-off-by: Serge E. Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
---
checkpoint/restart.c | 32 +++++++++++++++++++++++---------
1 files changed, 23 insertions(+), 9 deletions(-)
diff --git a/checkpoint/restart.c b/checkpoint/restart.c
index b87d0e1..13f48fb 100644
--- a/checkpoint/restart.c
+++ b/checkpoint/restart.c
@@ -569,16 +569,16 @@ static int wait_all_tasks_finish(struct ckpt_ctx *ctx)
return ret;
}
-/* setup restart-specific parts of ctx */
-static int init_restart_ctx(struct ckpt_ctx *ctx, pid_t pid)
+static struct task_struct *choose_root_task(struct ckpt_ctx *ctx, pid_t pid)
{
- struct task_struct *task;
- struct nsproxy *nsproxy;
+ struct task_struct *task = current;
- /*
- * No need for explicit cleanup here, because if an error
- * occurs then ckpt_ctx_free() is eventually called.
- */
+ if (ctx->uflags & RESTART_TASKSELF) {
+ ctx->root_pid = pid;
+ ctx->root_task = task;
+ get_task_struct(current);
+ return current;
+ }
read_lock(&tasklist_lock);
list_for_each_entry(task, ¤t->children, sibling) {
@@ -590,11 +590,25 @@ static int init_restart_ctx(struct ckpt_ctx *ctx, pid_t pid)
}
}
read_unlock(&tasklist_lock);
+ return task;
+}
+
+/* setup restart-specific parts of ctx */
+static int init_restart_ctx(struct ckpt_ctx *ctx, pid_t pid)
+{
+ struct nsproxy *nsproxy;
+
+ /*
+ * No need for explicit cleanup here, because if an error
+ * occurs then ckpt_ctx_free() is eventually called.
+ */
+
+ ctx->root_task = choose_root_task(ctx, pid);
if (!ctx->root_task)
return -ESRCH;
rcu_read_lock();
- nsproxy = task_nsproxy(task);
+ nsproxy = task_nsproxy(ctx->root_task);
if (nsproxy) {
get_nsproxy(nsproxy);
ctx->root_nsproxy = nsproxy;
--
1.6.1
next reply other threads:[~2009-06-15 20:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-15 20:20 Serge E. Hallyn [this message]
[not found] ` <20090615202022.GA18223-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-16 0:57 ` [PATCH 1/1] fix -ESRCH on self-restart Oren Laadan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090615202022.GA18223@us.ibm.com \
--to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.