All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Tomáš Szépe" <szepe@pinerecords.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [2.6.29.x+ FIX] CONFIG_FILE_LOCKING should not depend on CONFIG_BLOCK
Date: Mon, 15 Jun 2009 23:57:46 +0200	[thread overview]
Message-ID: <20090615215746.GC10235@louise.pinerecords.com> (raw)
In-Reply-To: <20090615144511.aae5e50d.akpm@linux-foundation.org>

> > Fix: CONFIG_FILE_LOCKING should not depend on CONFIG_BLOCK.
> > Patch against 2.6.29.*, 2.6.30, current.
> > 
> > inlined please find a trivial fix that makes it possible to run
> > complete systems out of an initramfs on current kernels again
> > (this last worked on 2.6.27.*).
> 
> Please describe the problem more completely.  Why is it not possible? 
> What goes wrong?  Your initramfs kernel has CONFIG_BLOCK=n?

Precisely.  Without this patch and with CONFIG_BLOCK unset, CONFIG_FILE_LOCKING
is forced to "n", which makes it impossible to run things as elementary as "mount",
they'll all fail with "flock(): not implemented" and similar.

I believe this is an apparent inconsistency between real code dependencies
(locks.o does not need the block layer compiled to successfully link) and
config symbol dependencies.

> Also, please do include a Signed-off-by: with each patch - see
> Documentation/SubmittingPatches for a description.

Ah, sorry, I haven't submitted a patch in years.

-- 
Tomáš Szépe <szepe@pinerecords.com>

      reply	other threads:[~2009-06-15 21:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-11  2:46 [2.6.29.x+ FIX] CONFIG_FILE_LOCKING should not depend on CONFIG_BLOCK Tomáš Szépe
2009-06-15 21:45 ` Andrew Morton
2009-06-15 21:57   ` Tomáš Szépe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090615215746.GC10235@louise.pinerecords.com \
    --to=szepe@pinerecords.com \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.