From: Andrew Morton <akpm@linux-foundation.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Steve Wise <swise@opengridcomputing.com>,
zygo.blaxell@xandros.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] LIB: remove unmatched write_lock() in gen_pool_destroy
Date: Tue, 16 Jun 2009 01:35:20 -0700 [thread overview]
Message-ID: <20090616013520.e9881fe7.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.LNX.2.00.0906161022210.7457@wotan.suse.de>
On Tue, 16 Jun 2009 10:23:08 +0200 (CEST) Jiri Kosina <jkosina@suse.cz> wrote:
> On Mon, 15 Jun 2009, Andrew Morton wrote:
>
> > > > this doesn't really qualify for trivial tree, as it introduces a
> > > > significant code change. Adding some CCs.
> > > Looks ok to me. Its dumb to aquire the lock you're gonna free anyway.
> > > Maybe some BUG_ON() that sez nobody better be holding this lock?
> > CONFIG_DEBUG_OBJECTS_FREE could detect the freeing of a held rwlock.
> > But probably it hasn't been wired up to handle rwlocks.
>
> Hmm, in fact ... am I just completely blind, or is the only user of
> CONFIG_DEBUG_OBJECTS_FREE the timer code?
Could be. That infrastructure hasn't really been followed up on yet.
There's also CONFIG_DEBUG_LOCK_ALLOC which perhaps could/should be
implemented via debugobjects.
next prev parent reply other threads:[~2009-06-16 8:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 17:37 [PATCH] LIB: remove unmatched write_lock() in gen_pool_destroy Zygo Blaxell
2009-06-15 21:35 ` Jiri Kosina
2009-06-15 22:04 ` Steve Wise
2009-06-15 22:29 ` Andrew Morton
2009-06-16 8:23 ` Jiri Kosina
2009-06-16 8:35 ` Andrew Morton [this message]
2009-06-15 22:26 ` Andrew Morton
2009-06-15 22:30 ` Steve Wise
2009-06-15 22:54 ` Andrew Morton
2009-06-16 0:27 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090616013520.e9881fe7.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=swise@opengridcomputing.com \
--cc=zygo.blaxell@xandros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.