From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: updates on ckpt-v16-dev Date: Tue, 16 Jun 2009 14:31:28 -0500 Message-ID: <20090616193128.GA3854@us.ibm.com> References: <4A37E901.1040403@cs.columbia.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <4A37E901.1040403-eQaUEPhvms7ENvBUuze7eA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Oren Laadan Cc: Linux Containers List-Id: containers.vger.kernel.org Quoting Oren Laadan (orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org): > > I pushed a bunch of updates on ckpt-v16-dev, including many fixes > and support for zombies. > > I did little testing, but preferred to shoot it out as I'll be out > for the next 24 hours at least. > > updates are to both user and kernel. > > Serge: please review the patch that fixes the user namespace. You removed the #include of from kernel/groups.c. I hear that works ok for x86, but on s390 it breaks my compiles. Also, in kernel/user_namespace.c:do_restore_userns() you have a #ifdef CONFIG_USER_NS, but user_namespace.o only gets compiled if CONFIG_USER_NS. Otherwise the user_ns patch does look good. I'm happy to do without the hackier-feeling flag. thanks, -serge