From: Frans Pop <elendil@planet.nl>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] IDE: consistently use type bool for wake enable variable
Date: Wed, 17 Jun 2009 00:16:15 +0200 [thread overview]
Message-ID: <200906170016.16716.elendil@planet.nl> (raw)
In-Reply-To: <20090616142554.7bce02f6@jbarnes-g45>
IDE: consistently use type bool for wake enable parameter
Other functions use type bool, so use that for pci_enable_wake as well.
Signed-off-by: Frans Pop <elendil@planet.nl>
---
Hi Jesse,
I've had this trivial patch sitting in my local branch for some time.
Please consider including.
Cheers,
FJP
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 1a91bf9..602052e 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -1203,7 +1203,7 @@ void pci_pme_active(struct pci_dev *dev, bool enable)
* Error code depending on the platform is returned if both the platform and
* the native mechanism fail to enable the generation of wake-up events
*/
-int pci_enable_wake(struct pci_dev *dev, pci_power_t state, int enable)
+int pci_enable_wake(struct pci_dev *dev, pci_power_t state, bool enable)
{
int error = 0;
bool pme_done = false;
diff --git a/include/linux/pci.h b/include/linux/pci.h
index 37f3430..6f6bc19 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -724,7 +724,7 @@ int pci_set_power_state(struct pci_dev *dev, pci_power_t state);
pci_power_t pci_choose_state(struct pci_dev *dev, pm_message_t state);
bool pci_pme_capable(struct pci_dev *dev, pci_power_t state);
void pci_pme_active(struct pci_dev *dev, bool enable);
-int pci_enable_wake(struct pci_dev *dev, pci_power_t state, int enable);
+int pci_enable_wake(struct pci_dev *dev, pci_power_t state, bool enable);
int pci_wake_from_d3(struct pci_dev *dev, bool enable);
pci_power_t pci_target_state(struct pci_dev *dev);
int pci_prepare_to_sleep(struct pci_dev *dev);
next prev parent reply other threads:[~2009-06-16 22:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-16 21:25 What's in pci-2.6.git Jesse Barnes
2009-06-16 22:16 ` Frans Pop [this message]
2009-06-16 22:18 ` [PATCH] IDE: consistently use type bool for wake enable variable Jesse Barnes
2009-06-16 22:35 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906170016.16716.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.