All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: xen-devel@lists.xensource.com
Cc: Zhigang Wang <zhigang.x.wang@oracle.com>,
	Akio Takebe <takebe_akio@jp.fujitsu.com>,
	Masaki Kanno <kanno.masaki@jp.fujitsu.com>,
	Dexuan Cui <dexuan.cui@intel.com>
Subject: [patch 02/17] xend: pass-through: Only call setupOneDevice() once per device
Date: Wed, 17 Jun 2009 12:56:14 +1000	[thread overview]
Message-ID: <20090617032044.831816536@vergenet.net> (raw)
In-Reply-To: 20090617025612.786241401@vergenet.net

[-- Attachment #1: call-setupOneDevice-once.patch --]
[-- Type: text/plain, Size: 1246 bytes --]

As observed by Dexuan Cui, when PCI devices are passed through at
domain-creation-time setupOneDevice() will be called twice.

Once via setupDevice() and once via econfigureDevice() which
is called in pci_device_configure().

This patch removes the first of these.

Cc: Masaki Kanno <kanno.masaki@jp.fujitsu.com>
Acked-by: Dexuan Cui <dexuan.cui@intel.com>
Signed-off-by: Simon Horman <horms@verge.net.au>

Index: xen-unstable.hg/tools/python/xen/xend/server/pciif.py
===================================================================
--- xen-unstable.hg.orig/tools/python/xen/xend/server/pciif.py	2009-06-15 11:24:00.000000000 +1000
+++ xen-unstable.hg/tools/python/xen/xend/server/pciif.py	2009-06-15 11:24:02.000000000 +1000
@@ -436,8 +436,6 @@ class PciController(DevController):
                                     ' same guest with %s'
                                 raise VmError(err_msg % (s, dev.name))
 
-        for (domain, bus, slot, func) in pci_dev_list:
-            self.setupOneDevice(domain, bus, slot, func)
         wPath = '/local/domain/0/backend/pci/%u/0/aerState' % (self.getDomid())
         self.aerStateWatch = xswatch(wPath, self._handleAerStateWatch)
         log.debug('pci: register aer watch %s', wPath)

-- 

  parent reply	other threads:[~2009-06-17  2:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-17  2:56 [patch 00/17] xend: pass-through: various clean-ups and infrastructure: take iii Simon Horman
2009-06-17  2:56 ` [patch 01/17] xend: Support older pciutils without -vmm option Simon Horman
2009-06-17  2:56 ` Simon Horman [this message]
2009-06-17  2:56 ` [patch 03/17] xend: pass-through: fix typo: spx -> sxp Simon Horman
2009-06-17  2:56 ` [patch 04/17] xend: pass-through: tidy up PciController() Simon Horman
2009-06-17  2:56 ` [patch 05/17] xend: pass-through: cleanupDevice: move and remove recently added vslot entry Simon Horman
2009-06-17  2:56 ` [patch 06/17] xend: pass-through: sxp.merge() cant deal with values being a list Simon Horman
2009-06-17  2:56 ` [patch 07/17] xend: pass-through: Remove PciDeviceNotFoundError, it is never used Simon Horman
2009-06-17  2:56 ` [patch 08/17] xend: pass-through: Use PCIDevice as the parameter for the constructor for PCIQuirk Simon Horman
2009-06-17  2:56 ` [patch 09/17] xend: pass-through: Common parse_pci_name() Simon Horman
2009-06-17  2:56 ` [patch 10/17] xend: pass-through: Use common parsing code in preprocess_pci() Simon Horman
2009-06-17  2:56 ` [patch 11/17] xend: pass-through: Add pci_dict_cmp() Simon Horman
2009-06-17  2:56 ` [patch 12/17] xend: pass-through: Move pci conversion functions to pci.py Simon Horman
2009-06-17  2:56 ` [patch 13/17] xend: pass-through: Use generic code in pci_opts_list_to_sxp() Simon Horman
2009-06-17  2:56 ` [patch 14/17] xend: pass-through: Add pci_tuple_to_dict() Simon Horman
2009-06-17  2:56 ` [patch 15/17] xend: pass-through: Use common parsing code in parse_pci_configuration() Simon Horman
2009-06-17  2:56 ` [patch 16/17] xend: pass-through: Use common parsing code in getDeviceConfiguration() Simon Horman
2009-06-17  2:56 ` [patch 17/17] xend: pass-through: Clean up hvm_destroyPCIDevice() Simon Horman
2009-06-17  6:12 ` [patch 00/17] xend: pass-through: various clean-ups and infrastructure: take iii Keir Fraser
2009-06-17  6:41   ` Keir Fraser
2009-06-17  6:55     ` Simon Horman
2009-06-17  7:17       ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090617032044.831816536@vergenet.net \
    --to=horms@verge.net.au \
    --cc=dexuan.cui@intel.com \
    --cc=kanno.masaki@jp.fujitsu.com \
    --cc=takebe_akio@jp.fujitsu.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=zhigang.x.wang@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.