From: Jens Axboe <jens.axboe@oracle.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: Warning in block code
Date: Wed, 17 Jun 2009 06:36:09 +0200 [thread overview]
Message-ID: <20090617043609.GT11363@kernel.dk> (raw)
In-Reply-To: <1245202783.21602.5.camel@pasglop>
On Wed, Jun 17 2009, Benjamin Herrenschmidt wrote:
> Hoy !
>
> I see that:
>
> block/blk-settings.c: In function ???blk_set_default_limits???:
> block/blk-settings.c:115: warning: large integer implicitly truncated to unsigned type
>
> Comes from
>
> lim->bounce_pfn = BLK_BOUNCE_ANY;
>
> With BLK_BOUNCE_ANY being a
>
> include/linux/blkdev.h:#define BLK_BOUNCE_ANY (-1ULL)
>
> And struct queue_limit.bounce_pfn is:
>
> unsigned long bounce_pfn;
>
> (The warning is fishy as both quantities are unsigned, but there -is-
> truncation happening here).
Should be safe to just make it -1UL now.
--
Jens Axboe
prev parent reply other threads:[~2009-06-17 4:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 1:39 Warning in block code Benjamin Herrenschmidt
2009-06-17 4:36 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090617043609.GT11363@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.