All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Tim Anderson <tanderson@mvista.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH 4/5] Move gcmp_probe to before the SMP ops
Date: Wed, 17 Jun 2009 09:21:18 +0100	[thread overview]
Message-ID: <20090617082118.GC13467@linux-mips.org> (raw)
In-Reply-To: <20090617000035.GG6346@shomer.az.mvista.com>

On Tue, Jun 16, 2009 at 05:00:35PM -0700, Tim Anderson wrote:

> @@ -358,10 +361,16 @@ void __init prom_init(void)
>  #ifdef CONFIG_SERIAL_8250_CONSOLE
>  	console_config();
>  #endif
> +	/* Early detection of CMP support */
> +	result = gcmp_probe(GCMP_BASE_ADDR, GCMP_ADDRSPACE_SZ);
> +
>  #ifdef CONFIG_MIPS_CMP
> -	register_smp_ops(&cmp_smp_ops);
> +	if (result) register_smp_ops(&cmp_smp_ops);

Keep the register_smp_ops on a separate line.

>  #endif
>  #ifdef CONFIG_MIPS_MT_SMP
> +#ifdef CONFIG_MIPS_CMP
> +	if (!result)
> +#endif
>  	register_smp_ops(&vsmp_smp_ops);

Suggested rewrite for readability and to silence checkpatch:

#ifdef CONFIG_MIPS_CMP
	if (!result)
		register_smp_ops(&vsmp_smp_ops);
#else
	register_smp_ops(&vsmp_smp_ops);
#endif

  Ralf

  reply	other threads:[~2009-06-17  8:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-17  0:00 [PATCH 4/5] Move gcmp_probe to before the SMP ops Tim Anderson
2009-06-17  8:21 ` Ralf Baechle [this message]
2009-06-17 15:40   ` Tim Anderson
2009-06-17 15:40     ` Tim Anderson
  -- strict thread matches above, loose matches on Subject: below --
2009-06-17 23:25 Tim Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090617082118.GC13467@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=linux-mips@linux-mips.org \
    --cc=tanderson@mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.