All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: liam@landv.org.uk
Cc: linux-lvm@redhat.com
Subject: [linux-lvm] Re: Exposing the same VG from two different disks
Date: Wed, 17 Jun 2009 11:48:45 -0400	[thread overview]
Message-ID: <20090617154845.GB638@redhat.com> (raw)
In-Reply-To: <11905247.42271245248829110.JavaMail.servlet@kundenserver>

On Wed, Jun 17 2009 at 10:27am -0400,
liam@landv.org.uk <liam@landv.org.uk> wrote:

> I've had a closer look at the vgimportclone script and I think the fix for the
>  lost filter is very straight forward. The errors are coming out of the final
>  vgscan and it seems to be caused by the LVM_SYSTEM_DIR variable being set to an 
> empty string rather than being unset. So I made the following change and it seemed 
> to fix the errors...
> 
> 327,333c327
> <
> < if [[ -z ${ORIG_LVM_SYS_DIR} ]]
> < then
> <       unset LVM_SYSTEM_DIR
> < else
> <       LVM_SYSTEM_DIR=${ORIG_LVM_SYS_DIR}
> < fi
> ---
> > LVM_SYSTEM_DIR=${ORIG_LVM_SYS_DIR}
> 
> I'm not sure if this change causes any issues but I'd be suprised.

Liam,

Looks good, I've committed your fix along with various other fixes to
vgimportclone.

Thanks,
Mike

  reply	other threads:[~2009-06-17 15:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-17 14:27 [linux-lvm] Exposing the same VG from two different disks liam
2009-06-17 15:48 ` Mike Snitzer [this message]
2009-06-19  4:39 ` chris procter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090617154845.GB638@redhat.com \
    --to=snitzer@redhat.com \
    --cc=liam@landv.org.uk \
    --cc=linux-lvm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.