From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 11BF6B7230 for ; Thu, 18 Jun 2009 06:14:09 +1000 (EST) Date: Thu, 18 Jun 2009 00:13:29 +0400 From: Anton Vorontsov To: Grant Likely Subject: Re: [PATCH] sdhci: Add support for hosts that are only capable of 1-bit transfers Message-ID: <20090617201329.GA9149@oksana.dev.rtsoft.ru> References: <20090611201545.GA15942@oksana.dev.rtsoft.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 In-Reply-To: Cc: linuxppc-dev@ozlabs.org, Pierre Ossman , devicetree-discuss@ozlabs.org, sdhci-devel@lists.ossman.eu Reply-To: avorontsov@ru.mvista.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, Jun 13, 2009 at 09:40:02AM -0600, Grant Likely wrote: > On Thu, Jun 11, 2009 at 2:15 PM, Anton > Vorontsov wrote: > > Some hosts (hardware configurations, or particular SD/MMC slots) may > > not support 4-bit bus. For example, on MPC8569E-MDS boards we can > > switch between serial (1-bit only) and nibble (4-bit) modes, thought > > we have to disable more peripherals to work in 4-bit mode. > > > > Along with some small core changes, this patch modifies sdhci-of > > driver, so that now it looks for "mode" property in the device-tree. > > > > Signed-off-by: Anton Vorontsov > > --- > > > > Pierre, I'm not sure if a quirk would be appropriate here. If so, > > I can redo the patch with FORCE_1_BIT_DATA quirk. > > > > Thanks, > > > >  Documentation/powerpc/dts-bindings/fsl/esdhc.txt |    2 ++ > >  drivers/mmc/host/sdhci-of.c                      |    7 +++++++ > >  drivers/mmc/host/sdhci-pci.c                     |    1 + > >  drivers/mmc/host/sdhci.c                         |    2 +- > >  4 files changed, 11 insertions(+), 1 deletions(-) > > > > diff --git a/Documentation/powerpc/dts-bindings/fsl/esdhc.txt b/Documentation/powerpc/dts-bindings/fsl/esdhc.txt > > index 5093ddf..298b865 100644 > > --- a/Documentation/powerpc/dts-bindings/fsl/esdhc.txt > > +++ b/Documentation/powerpc/dts-bindings/fsl/esdhc.txt > > @@ -10,6 +10,8 @@ Required properties: > >   - interrupts : should contain eSDHC interrupt. > >   - interrupt-parent : interrupt source phandle. > >   - clock-frequency : specifies eSDHC base clock frequency. > > +  - mode : specifies eSDHC mode, valid values are: "1-bit" and "4-bit". > > +    If mode is unspecified, then 4-bit mode is assumed. > > In light of Pierre's comment that 4-bit is mandatory and this is a > deviation, perhaps it would be better to define an empty property to > indicate that only 1-bit transfers work. Maybe something along the > lines of "sdhc-1-bit-only"? Yeah, since it turned up to be a quirk, we'd better use a named property. (I think that by convention we should use commas for controller-specific properties, i.e. "sdhci,property".) Thanks! -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Vorontsov Subject: Re: [PATCH] sdhci: Add support for hosts that are only capable of 1-bit transfers Date: Thu, 18 Jun 2009 00:13:29 +0400 Message-ID: <20090617201329.GA9149@oksana.dev.rtsoft.ru> References: <20090611201545.GA15942@oksana.dev.rtsoft.ru> Reply-To: avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-mnsaURCQ41sdnm+yROfE0A@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-mnsaURCQ41sdnm+yROfE0A@public.gmane.org To: Grant Likely Cc: linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, Pierre Ossman , devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, sdhci-devel-qjLDD68F18NoYZYVwN2jqg@public.gmane.org List-Id: devicetree@vger.kernel.org T24gU2F0LCBKdW4gMTMsIDIwMDkgYXQgMDk6NDA6MDJBTSAtMDYwMCwgR3JhbnQgTGlrZWx5IHdy b3RlOgo+IE9uIFRodSwgSnVuIDExLCAyMDA5IGF0IDI6MTUgUE0sIEFudG9uCj4gVm9yb250c292 PGF2b3JvbnRzb3ZAcnUubXZpc3RhLmNvbT4gd3JvdGU6Cj4gPiBTb21lIGhvc3RzIChoYXJkd2Fy ZSBjb25maWd1cmF0aW9ucywgb3IgcGFydGljdWxhciBTRC9NTUMgc2xvdHMpIG1heQo+ID4gbm90 IHN1cHBvcnQgNC1iaXQgYnVzLiBGb3IgZXhhbXBsZSwgb24gTVBDODU2OUUtTURTIGJvYXJkcyB3 ZSBjYW4KPiA+IHN3aXRjaCBiZXR3ZWVuIHNlcmlhbCAoMS1iaXQgb25seSkgYW5kIG5pYmJsZSAo NC1iaXQpIG1vZGVzLCB0aG91Z2h0Cj4gPiB3ZSBoYXZlIHRvIGRpc2FibGUgbW9yZSBwZXJpcGhl cmFscyB0byB3b3JrIGluIDQtYml0IG1vZGUuCj4gPgo+ID4gQWxvbmcgd2l0aCBzb21lIHNtYWxs IGNvcmUgY2hhbmdlcywgdGhpcyBwYXRjaCBtb2RpZmllcyBzZGhjaS1vZgo+ID4gZHJpdmVyLCBz byB0aGF0IG5vdyBpdCBsb29rcyBmb3IgIm1vZGUiIHByb3BlcnR5IGluIHRoZSBkZXZpY2UtdHJl ZS4KPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBBbnRvbiBWb3JvbnRzb3YgPGF2b3JvbnRzb3ZAcnUu bXZpc3RhLmNvbT4KPiA+IC0tLQo+ID4KPiA+IFBpZXJyZSwgSSdtIG5vdCBzdXJlIGlmIGEgcXVp cmsgd291bGQgYmUgYXBwcm9wcmlhdGUgaGVyZS4gSWYgc28sCj4gPiBJIGNhbiByZWRvIHRoZSBw YXRjaCB3aXRoIEZPUkNFXzFfQklUX0RBVEEgcXVpcmsuCj4gPgo+ID4gVGhhbmtzLAo+ID4KPiA+ IMKgRG9jdW1lbnRhdGlvbi9wb3dlcnBjL2R0cy1iaW5kaW5ncy9mc2wvZXNkaGMudHh0IHwgwqAg wqAyICsrCj4gPiDCoGRyaXZlcnMvbW1jL2hvc3Qvc2RoY2ktb2YuYyDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoHwgwqAgwqA3ICsrKysrKysKPiA+IMKgZHJpdmVycy9tbWMvaG9zdC9z ZGhjaS1wY2kuYyDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCB8IMKgIMKgMSArCj4gPiDC oGRyaXZlcnMvbW1jL2hvc3Qvc2RoY2kuYyDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCB8IMKgIMKgMiArLQo+ID4gwqA0IGZpbGVzIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyks IDEgZGVsZXRpb25zKC0pCj4gPgo+ID4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vcG93ZXJw Yy9kdHMtYmluZGluZ3MvZnNsL2VzZGhjLnR4dCBiL0RvY3VtZW50YXRpb24vcG93ZXJwYy9kdHMt YmluZGluZ3MvZnNsL2VzZGhjLnR4dAo+ID4gaW5kZXggNTA5M2RkZi4uMjk4Yjg2NSAxMDA2NDQK PiA+IC0tLSBhL0RvY3VtZW50YXRpb24vcG93ZXJwYy9kdHMtYmluZGluZ3MvZnNsL2VzZGhjLnR4 dAo+ID4gKysrIGIvRG9jdW1lbnRhdGlvbi9wb3dlcnBjL2R0cy1iaW5kaW5ncy9mc2wvZXNkaGMu dHh0Cj4gPiBAQCAtMTAsNiArMTAsOCBAQCBSZXF1aXJlZCBwcm9wZXJ0aWVzOgo+ID4gwqAgLSBp bnRlcnJ1cHRzIDogc2hvdWxkIGNvbnRhaW4gZVNESEMgaW50ZXJydXB0Lgo+ID4gwqAgLSBpbnRl cnJ1cHQtcGFyZW50IDogaW50ZXJydXB0IHNvdXJjZSBwaGFuZGxlLgo+ID4gwqAgLSBjbG9jay1m cmVxdWVuY3kgOiBzcGVjaWZpZXMgZVNESEMgYmFzZSBjbG9jayBmcmVxdWVuY3kuCj4gPiArIMKg LSBtb2RlIDogc3BlY2lmaWVzIGVTREhDIG1vZGUsIHZhbGlkIHZhbHVlcyBhcmU6ICIxLWJpdCIg YW5kICI0LWJpdCIuCj4gPiArIMKgIMKgSWYgbW9kZSBpcyB1bnNwZWNpZmllZCwgdGhlbiA0LWJp dCBtb2RlIGlzIGFzc3VtZWQuCj4gCj4gSW4gbGlnaHQgb2YgUGllcnJlJ3MgY29tbWVudCB0aGF0 IDQtYml0IGlzIG1hbmRhdG9yeSBhbmQgdGhpcyBpcyBhCj4gZGV2aWF0aW9uLCBwZXJoYXBzIGl0 IHdvdWxkIGJlIGJldHRlciB0byBkZWZpbmUgYW4gZW1wdHkgcHJvcGVydHkgdG8KPiBpbmRpY2F0 ZSB0aGF0IG9ubHkgMS1iaXQgdHJhbnNmZXJzIHdvcmsuICBNYXliZSBzb21ldGhpbmcgYWxvbmcg dGhlCj4gbGluZXMgb2YgInNkaGMtMS1iaXQtb25seSI/CgpZZWFoLCBzaW5jZSBpdCB0dXJuZWQg dXAgdG8gYmUgYSBxdWlyaywgd2UnZCBiZXR0ZXIgdXNlIGEgbmFtZWQKcHJvcGVydHkuCgooSSB0 aGluayB0aGF0IGJ5IGNvbnZlbnRpb24gd2Ugc2hvdWxkIHVzZSBjb21tYXMgZm9yCmNvbnRyb2xs ZXItc3BlY2lmaWMgcHJvcGVydGllcywgaS5lLiAic2RoY2kscHJvcGVydHkiLikKCgpUaGFua3Mh CgotLSAKQW50b24gVm9yb250c292CmVtYWlsOiBjYm91YXRtYWlscnVAZ21haWwuY29tCmlyYzov L2lyYy5mcmVlbm9kZS5uZXQvYmQyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmRldmljZXRyZWUtZGlzY3VzcyBtYWlsaW5nIGxpc3QKZGV2aWNldHJlZS1k aXNjdXNzQG96bGFicy5vcmcKaHR0cHM6Ly9vemxhYnMub3JnL21haWxtYW4vbGlzdGluZm8vZGV2 aWNldHJlZS1kaXNjdXNzCg==