From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sukadev Bhattiprolu Subject: [RFC][PATCH 1/2] Deny CLONE_PARENT|CLONE_NEWPID combination Date: Wed, 17 Jun 2009 19:49:34 -0700 Message-ID: <20090618024934.GA31672@us.ibm.com> References: <20090618024743.GA31515@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20090618024743.GA31515-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org, "Eric W. Biederman" , Oleg Nesterov , roland-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Pavel Emelyanov , Alexey Cc: Containers , "David C. Hansen" List-Id: containers.vger.kernel.org Deny CLONE_PARENT|CLONE_NEWPID combination. CLONE_PARENT was probably used to implement an older threading model. If so, for consistency with CLONE_THREAD, the CLONE_PARENT|CLONE_NEWPID combination should also fail with -EINVAL. Signed-off-by: Sukadev Bhattiprolu --- kernel/pid_namespace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-mmotm/kernel/pid_namespace.c =================================================================== --- linux-mmotm.orig/kernel/pid_namespace.c 2009-06-17 18:19:42.000000000 -0700 +++ linux-mmotm/kernel/pid_namespace.c 2009-06-17 18:19:58.000000000 -0700 @@ -118,7 +118,7 @@ struct pid_namespace *copy_pid_ns(unsign { if (!(flags & CLONE_NEWPID)) return get_pid_ns(old_ns); - if (flags & CLONE_THREAD) + if (flags & (CLONE_THREAD|CLONE_PARENT)) return ERR_PTR(-EINVAL); return create_pid_namespace(old_ns); }