From: Tony Lindgren <tony@atomide.com>
To: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
Cc: linux-omap@vger.kernel.org, Fernando Guzman Lugo <x0095840@ti.com>
Subject: Re: [PATCH 1/1] IOMMU: function flush_iotlb_page is not flushing correct entry
Date: Thu, 18 Jun 2009 08:05:56 +0300 [thread overview]
Message-ID: <20090618050554.GD8079@atomide.com> (raw)
In-Reply-To: <1245058706-22504-1-git-send-email-Hiroshi.DOYU@nokia.com>
* Hiroshi DOYU <Hiroshi.DOYU@nokia.com> [090615 12:39]:
> From: Fernando Guzman Lugo <x0095840@ti.com>
>
> From: Fernando Guzman Lugo <x0095840@ti.com>
>
> The function flush_iotlb_page is not loading the CAM register with
> the correct entry to be flushed, so it is flushing other entry
>
> Signed-off-by: Fernando Guzman Lugo <x0095840@ti.com>
> Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
> ---
> arch/arm/plat-omap/iommu.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> mode change 100644 => 100755 arch/arm/plat-omap/iommu.c
>
> diff --git a/arch/arm/plat-omap/iommu.c b/arch/arm/plat-omap/iommu.c
> old mode 100644
> new mode 100755
This made some bad mode changes as noted by Paul, will fix in l-o master
and in omap-fixes. But please check your repos too!
Tony
> index 4cf449f..4a03013
> --- a/arch/arm/plat-omap/iommu.c
> +++ b/arch/arm/plat-omap/iommu.c
> @@ -298,7 +298,7 @@ void flush_iotlb_page(struct iommu *obj, u32 da)
> if ((start <= da) && (da < start + bytes)) {
> dev_dbg(obj->dev, "%s: %08x<=%08x(%x)\n",
> __func__, start, da, bytes);
> -
> + iotlb_load_cr(obj, &cr);
> iommu_write_reg(obj, 1, MMU_FLUSH_ENTRY);
> }
> }
> --
> 1.6.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-06-18 7:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-15 9:38 [PATCH 1/1] IOMMU: function flush_iotlb_page is not flushing correct entry Hiroshi DOYU
2009-06-17 9:47 ` [APPLIED] [PATCH 1/1] IOMMU: function flush_iotlb_page is not flushing Tony Lindgren
2009-06-18 5:05 ` Tony Lindgren [this message]
2009-06-18 7:52 ` [PATCH 1/1] IOMMU: function flush_iotlb_page is not flushing correct entry Hiroshi DOYU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090618050554.GD8079@atomide.com \
--to=tony@atomide.com \
--cc=Hiroshi.DOYU@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=x0095840@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.