From: Gleb Natapov <gleb@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] Call piix3_reset() on system reset.
Date: Thu, 18 Jun 2009 09:02:56 +0300 [thread overview]
Message-ID: <20090618060255.GA20289@redhat.com> (raw)
In-Reply-To: <f43fc5580906171010j28966a08k4148a8a4ff6461be@mail.gmail.com>
On Wed, Jun 17, 2009 at 08:10:23PM +0300, Blue Swirl wrote:
> On 6/17/09, Gleb Natapov <gleb@redhat.com> wrote:
> > Also zero pci_irq_levels on reset to avoid stuck irq after reset.
> >
> > Signed-off-by: Gleb Natapov <gleb@redhat.com>
> > Signed-off-by: Yaniv Kamay <ykamay@redhat.com>
>
> Thanks, applied.
Thanks, but without 1/3 reset is still buggy. Look at hw/pci.c:pci_set_irq()
If pci_dev->irq_state[irq_num] == 1 at reset time it will stay 1 after
reset too. When device will try to race IRQ line after reset it will
fail to do so. And if bus->irq_count[] is not zeroed you have another
set of problems. If you don't like that pci_bus_reset() reset per device
state (why?) it is possible to create pci_device_reset(), but then we
will have to fix 25 devices to call it. Complication for no good
reason. IMHO pci_device_save/load should be handled in hw/pci.c too.
What are the disadvantages?
--
Gleb.
next prev parent reply other threads:[~2009-06-18 6:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 16:32 [Qemu-devel] [PATCH 1/3] Add pci_bus_reset() function Gleb Natapov
2009-06-17 16:32 ` [Qemu-devel] [PATCH 2/3] Call piix3_reset() on system reset Gleb Natapov
2009-06-17 17:10 ` Blue Swirl
2009-06-18 6:02 ` Gleb Natapov [this message]
2009-06-17 16:32 ` [Qemu-devel] [PATCH 3/3] Register usb-uhci reset function Gleb Natapov
2009-06-17 17:11 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090618060255.GA20289@redhat.com \
--to=gleb@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.