From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH][SVM] fix spinlock panic Date: Thu, 18 Jun 2009 13:27:44 +0200 Message-ID: <200906181327.45103.Christoph.Egger@amd.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On Thursday 18 June 2009 11:47:07 Keir Fraser wrote: > On 18/06/2009 10:25, "Christoph Egger" wrote: > >> dangerous to reset the ASID generation back to zero); Also, as well as > >> not reallocating hsa and root_vmcb, we don't re-init them either. I > >> don't know ehether that strictly matters but obviously we could easily > >> re-jig the code to always clear_page() those pages unconditionally. > > > > Thanks for it. Regarding ASID, I will ask back. > > Now, I trigger an ASSERT() called by setup_vmcb_dump(): > > > > (XEN) Assertion 'key_table[key].u.handler == ((void*)0)' failed at > > keyhandler.c:68 > > Oh good grief, I got the test at the top of start_svm() inverted. Please > try changeset 19798 which fixes this. Yes, works now. Tnx. Can you apply c/s 19784 and c/s 19798 to xen-3.4-testing and xen-3.3-testing, please ? Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632