From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 0/2] orphan lock fixes for local mode.
Date: Thu, 18 Jun 2009 10:21:27 -0700 [thread overview]
Message-ID: <20090618172127.GA29363@mail.oracle.com> (raw)
In-Reply-To: <4A3A65EA.1060804@oracle.com>
On Thu, Jun 18, 2009 at 09:06:02AM -0700, Sunil Mushran wrote:
> Joel Becker wrote:
> > On Thu, Jun 18, 2009 at 03:48:08PM +0800, Tao Ma wrote:
> >
> >> Hi Joel/Srini,
> >> Here are 2 patches for orphan lock in local mode.
> >> patch 1:
> >> In local mode, we don't need lvb, so don't init it.
> >> patch 2:
> >> In local mode, orphan lock and unlock don't need to go to dlm part.
> >>
> > I would think we don't even need the orphan scan in local mode.
> >
> > Joel
>
> Tao, Good catch.
>
> Yes, we don't need the orphan scan in local mount. The earlier patch
> that scans all the orphans slots mount should be sufficient.
>
> Not calling ocfs2_orphan_scan_init() in ocfs2_initialize_super() should
> be sufficient. But we should add Tao's patch 2 too for completeness.
Do we need the hard_readonly check like other lock types?
Joel
--
"Baby, even the losers
Get luck sometimes.
Even the losers
Keep a little bit of pride."
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2009-06-18 17:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-18 7:48 [Ocfs2-devel] [PATCH 0/2] orphan lock fixes for local mode Tao Ma
2009-06-18 7:53 ` [Ocfs2-devel] [PATCH 1/2] ocfs2: Don't init lvb of orphan lock in " Tao Ma
2009-06-18 7:53 ` [Ocfs2-devel] [PATCH 2/2] ocfs2: Don't call dlm for orphan scan lock if volume is local Tao Ma
2009-06-18 15:06 ` [Ocfs2-devel] [PATCH 0/2] orphan lock fixes for local mode Joel Becker
2009-06-18 16:06 ` Sunil Mushran
2009-06-18 17:21 ` Joel Becker [this message]
2009-06-18 17:33 ` Sunil Mushran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090618172127.GA29363@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.